From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [RFC] Correctly handling MinGW-w64 Date: Sun, 16 Nov 2014 20:04:32 -0800 Organization: UCLA Computer Science Department Message-ID: <546973D0.7050306@cs.ucla.edu> References: <87r3x2qyjg.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1416197109 17495 80.91.229.3 (17 Nov 2014 04:05:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Nov 2014 04:05:09 +0000 (UTC) To: =?UTF-8?B?w5NzY2FyIEZ1ZW50ZXM=?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 17 05:05:03 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XqDYk-0001DW-O2 for ged-emacs-devel@m.gmane.org; Mon, 17 Nov 2014 05:05:02 +0100 Original-Received: from localhost ([::1]:45985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYj-0004le-W1 for ged-emacs-devel@m.gmane.org; Sun, 16 Nov 2014 23:05:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYZ-0004lT-GY for emacs-devel@gnu.org; Sun, 16 Nov 2014 23:04:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqDYS-0005tE-03 for emacs-devel@gnu.org; Sun, 16 Nov 2014 23:04:51 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:55008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYR-0005st-R1 for emacs-devel@gnu.org; Sun, 16 Nov 2014 23:04:43 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id F03EAA6002B; Sun, 16 Nov 2014 20:04:41 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ziw4hHgDWh8J; Sun, 16 Nov 2014 20:04:33 -0800 (PST) Original-Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 51893A6000C; Sun, 16 Nov 2014 20:04:33 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 In-Reply-To: <87r3x2qyjg.fsf@wanadoo.es> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177384 Archived-At: =C3=93scar Fuentes wrote: > +dnl We need to distinguish MinGW32 toolset from its spin-off > +dnl MinGW-w64. (This has nothing to do with word size.) > +MINGW_W64=3Dno > +if test $opsys =3D mingw32; then > + AC_CHECK_DECL(__MINGW64_VERSION_MAJOR, > + MINGW_W64=3Dyes, > + MINGW_W64=3Dno, > + [#include <_mingw.h>]) > + if test "$MINGW_W64" =3D "yes"; then > + AC_DEFINE([MINGW_W64], 1, > + [Define to 1 if you are using the MinGW-w64 toolset, regardl= ess of word size.]) > + fi > +fi Why does the above need to be in configure.ac? Can the relevant code jus= t=20 inspect __MINGW64_VERSION_MAJOR instead of inspecting MINGW_W64? Or, if = we=20 prefer to use our own symbol, can we just put something like this: #ifdef __MINGW64_VERSION_MAJOR # define MINGW_W64 1 #endif into ms-w32.h or into some other header specific to Microsoft Windows?