From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tobias Gerdin Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse' Date: Tue, 10 Jul 2018 16:03:19 +0200 Message-ID: <546626ED-35AD-4E9C-84E9-D5F477FBD8E6@shaolinkulturcenter.se> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_3543443D-8678-4F06-A9A8-7DCEABA67AEC" X-Trace: blaine.gmane.org 1531232823 26544 195.159.176.226 (10 Jul 2018 14:27:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Jul 2018 14:27:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: eller.helmut@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 10 16:26:59 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fctbW-0006mm-Ua for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 16:26:59 +0200 Original-Received: from localhost ([::1]:48125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fctde-00054y-0X for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 10:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fctEk-0007qY-CV for emacs-devel@gnu.org; Tue, 10 Jul 2018 10:03:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fctEh-0007Ln-Al for emacs-devel@gnu.org; Tue, 10 Jul 2018 10:03:26 -0400 Original-Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:37267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fctEh-0007LS-1Z for emacs-devel@gnu.org; Tue, 10 Jul 2018 10:03:23 -0400 Original-Received: by mail-lj1-x231.google.com with SMTP id v9-v6so6508850ljk.4 for ; Tue, 10 Jul 2018 07:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shaolinkulturcenter-se.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:message-id:date:cc:to; bh=D18DNORPilxClfSI4kVt0u3HFzPnVgjulUEdcz2h26w=; b=aBpvqydJ3T6KFNFORrkFNWuq24nuDLWGA42VTv8z6Smvjz0Vw6raAvpqKw1mn82kHU 9Z7ryxqfgem6gRI6JZ6QaZmr/ShPpnhF8v/SxeXvXlJOfAjti/AdS7ZKx2tahCbZLX8W DWxZCk6afGJgOE0DIPpiAz1YeT5SATx3vQCdjkNVYgUf41vud9GLFE6aeFWwLOkmbmVR 0wDzDUY4KRViJ5k99A23AgnP11zXURBPCQBONiVvaihFYwRMyab95FsOl8ZqU/7Nk68D jhI7ZkUifSAtKw1oycyOA7b5bw4b+Hv85n+TkKdW5nb9ssxnBR+DO0uoeNMY7+3pwS5B UrxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:cc:to; bh=D18DNORPilxClfSI4kVt0u3HFzPnVgjulUEdcz2h26w=; b=jn1CvPIhNQhgBMM38zZas10xOjA/6wAOg9tp+qjFG93kxSIctAsMNmYygB45rgvUtW 3l1NnTnB6HOLjVZfc2k+vyCaAFl1alaKrPWn7+FsxPtIaWpb47xUsDxenG2ixDZLCngK wz9ChF5kq3zPJW+9nNeRaHKoPS7mLLIxLVhMdKft34lnDr4xxj5WoTUjZ/Zl1ShPqRjx IltxuY7SPnIcx82b2h93qEB1qseP62LgVzxzSedoxIHqrq2t3V6902rb0eJJ21kLUNcu ilhn3ew1EnhFnyXjvV5210+hWjZ05CzfUnYkqTL7C0064smzuZqklAgHk297UPjB1xIE cjag== X-Gm-Message-State: APt69E1YYwQTL6b/sXD6Xl5h9dMWBta+pz7hclOILLwC3pMIknmR2n2w Vy7JDmj7kNEByO79ukzodkqJNw== X-Google-Smtp-Source: AAOMgpcg3tyI3mzoPKpJii+t6iJ1wroqhfVRKdnAAcfQKIZeDUHDORAnlL+Ca4XWxKrTGMf+P4rong== X-Received: by 2002:a2e:1301:: with SMTP id 1-v6mr4946895ljt.56.1531231401189; Tue, 10 Jul 2018 07:03:21 -0700 (PDT) Original-Received: from tobias-mbp.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id y68-v6sm4829561lfd.66.2018.07.10.07.03.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 07:03:20 -0700 (PDT) X-Mailer: Apple Mail (2.3445.8.2) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::231 X-Mailman-Approved-At: Tue, 10 Jul 2018 10:29:05 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227209 Archived-At: --Apple-Mail=_3543443D-8678-4F06-A9A8-7DCEABA67AEC Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > > On Mon, Jul 09 2018, Stefan Monnier wrote: > > > Maybe they can be merged, but maybe they are meant to behave differently > > (e.g. xref-find-definitions-at-mouse should never prompt the user about > > which identifier to use?). > > For "mouse mode" it might also be more natural to use an actual popup > menu instead of the *xref* buffer to display a list of choices. > > Helmut Good idea, I will try to look in to this! -Tobias --Apple-Mail=_3543443D-8678-4F06-A9A8-7DCEABA67AEC Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii 

On Mon, Jul 09 2018, Stefan Monnier wrote:

> Maybe they can be merged, but maybe they are meant to behave differently
> (e.g. xref-find-definitions-at-mouse should never prompt the user about
> which identifier to use?).

For "mouse mode" it might also be more natural to use an actual popup
menu instead of the *xref* buffer to display a list of choices.

Helmut

Good idea, I will try to look in to this!
-Tobias
--Apple-Mail=_3543443D-8678-4F06-A9A8-7DCEABA67AEC--