From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] sequence manipulation functions Date: Fri, 07 Nov 2014 17:43:07 +0000 Message-ID: <545D04AB.6090201@dancol.org> References: <87oasmmwzt.fsf@gmail.com> <87bnolslph.fsf@gmail.com> <87zjc2dic0.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ETHN3AgOOJS7tLLukusGfnPb25EwDW4D1" X-Trace: ger.gmane.org 1415382223 16661 80.91.229.3 (7 Nov 2014 17:43:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Nov 2014 17:43:43 +0000 (UTC) Cc: Emacs developers To: Nicolas Petton , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 07 18:43:37 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XmnZP-0004iS-Cy for ged-emacs-devel@m.gmane.org; Fri, 07 Nov 2014 18:43:35 +0100 Original-Received: from localhost ([::1]:33163 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmnZP-0006AH-1h for ged-emacs-devel@m.gmane.org; Fri, 07 Nov 2014 12:43:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmnZG-00069i-8V for emacs-devel@gnu.org; Fri, 07 Nov 2014 12:43:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmnZ9-00079b-TM for emacs-devel@gnu.org; Fri, 07 Nov 2014 12:43:26 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:39283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmnZ9-000774-Jw for emacs-devel@gnu.org; Fri, 07 Nov 2014 12:43:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=5lCsCBvNp+wtvh7Jq1JnWxQ76mFP+lky9rMLM4uk5kk=; b=nm6tLsS33flPxpzY07ljIyIRc3inv7MhSuZ7s12YL2ua0E2ek6ZYApuvqffLF9MPm2T1ICjairnILUn5LnzdREcyt7jIE4UfyCVFoY67t3sumq6bgs3wirgySsGiUHFmqzLVLJcq1BfstBdddpMYzp7HMdQitJw9TUEFOqigLFrwf6aw5FMpnQbWXaVpeVqFR07AjeUwy57gsmFPyuhRw9Gvrz23gAStOjWdJYw+1jfNnVFbAxKmZlGxcb0rNjt+PsAx5LAa2tdJKSBKyKBnrFID2iaUmAa+Hp6T8iEwA6pldyHPaf31NOZpme2zu8FXSX3hJBxUHbWEeh2/hqx2lA==; Original-Received: from [199.201.65.2] (helo=[172.30.31.126]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1XmnZ8-00046Y-Ha; Fri, 07 Nov 2014 09:43:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 In-Reply-To: <87zjc2dic0.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176543 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ETHN3AgOOJS7tLLukusGfnPb25EwDW4D1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/07/2014 05:35 PM, Nicolas Petton wrote: > Hi, >=20 > Here is a patch containing the new version of sequences.el and its > associated test file Why do you want to dump these functions with Emacs? > +(defun seq-sort (seq pred) > + "Return a sorted list of the elements of SEQ compared using PRED." > + (if (listp seq) > + (sort (seq-copy seq) pred) > + (seq-sort (append seq nil) pred))) If you insist on adding seq- prefixed functions (and I don't think you should, contra rms), you should make an alias, not a wrapper. You're aware that we have native sort support for vectors and don't to coerce to a list first, right? --ETHN3AgOOJS7tLLukusGfnPb25EwDW4D1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJUXQSrAAoJEN4WImmbpWBl8ZkP/Rpgz0+hs5Mhk+uz7C15y/ZE OzBq4igkn/ibOqFyLKqA5CBqj1Vhkuf6Rr5bqkLySUBEJtdCZ563KQOCyv2kdWsZ UVZH7NIetMg81lhwlI4geGpsbeSncnOtgfOFwOktSTUD2LHJ2S3Dlhd31secYSMt vKG1WJiEiSlZLR6TfQBcDoSok9UxRnq52XyM4MZZGH1xWYlVJTNEt2PFi7XEHfba 5VwusFyh52/g6aMN6TWgofsO292s/kCbcS3SK/7c5ea4LwFD9PKK009qaQWCGW+I 35OJr8BDpL+Fj+ewflvyvjEnqKuZyNE1bFXng/JbHFdUonuicG53swbsSr+ChHrO T+AZ7L4MLmk2NkvwwPPo3rbpsWFqyTMcY0jXNyAk8s78QGxiXAQoI4SJAy/D1DnG zSBBRLPqn98qoAgvjCFUrfwKm7JU135jv8Zlz/8XFBaFx++jHhoGMer509NZJ4IR jJ2cVZHdpMvxJAUjX1EfoPcCUkkRL3ZHVecyTa2FCIDvYq1bepL702y9XXT+QQnK eJ1jwLwi+/i1jBdsXqEZJNiYJDv0j2F4G2YiW+3HpazVRHo+Z3NyXKwyy/gIjBAK 1Fv0SlChS4NgavO1d2kEEhN3Bvh7RhnJuonHnijhNFcsLiqlbgsHGaE0JmUK0BVl F0g3qenfI4A0h5ZlSqdF =lKpm -----END PGP SIGNATURE----- --ETHN3AgOOJS7tLLukusGfnPb25EwDW4D1--