From: Daniel Colascione <dancol@dancol.org>
To: Alan Mackenzie <acm@muc.de>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: "enum class" supports for cc-mode
Date: Wed, 29 Oct 2014 17:02:28 +0000 [thread overview]
Message-ID: <54511DA4.4060002@dancol.org> (raw)
In-Reply-To: <20141029164915.GC2953@acm.acm>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
On 10/29/2014 04:49 PM, Alan Mackenzie wrote:
> Hi, Daniel.
>
> On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
>> Here's a small patch that teaches cc-mode about C++11 "enum class" syntax.
>> See http://msdn.microsoft.com/en-us/library/2dzy4k6e.aspx
>
>> Alan, can you take a look?
>
> Thanks for this, it looks good. I'll definitely install it (with proper
> attribution).
Thanks.
> Just one or two little details:
> (i) You've used `eql' rather than `eq' for comparing things in a few
> places. Is there any reason for this?
eql is a good habit for numbers; = and eq would work just as well in
these contexts though in Emacs.
> (ii) c-after-brace-list-key will be "\\<\\>" (not nil) for non-C++
> languages, I think. It's definition in cc-langs.el needs tweaking a
> bit to make it nil.
Good point. Would you mind making this change?
> (iii) There's a question as to whether the backward searching in
> c-backward-colon-prefixed-type should have an optional search limit.
> But the existing c-backward-over-enum-header doesn't, so that's
> something new to think about.
I figure that the search will stop soon enough when we come across a
token that can't be part of the enum header. Placing a generically
correct bound on it seemed hard.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-29 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 18:36 "enum class" supports for cc-mode Daniel Colascione
2014-10-29 16:49 ` Alan Mackenzie
2014-10-29 17:02 ` Daniel Colascione [this message]
2014-10-30 16:21 ` Alan Mackenzie
2014-10-30 18:56 ` Daniel Colascione
2014-10-31 20:35 ` Glenn Morris
2014-11-01 10:39 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54511DA4.4060002@dancol.org \
--to=dancol@dancol.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.