From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Roland Winkler" Newsgroups: gmane.emacs.bugs Subject: bug#37957: BibTeX dialect not set if local variables disabled Date: Wed, 30 Oct 2019 13:21:48 -0500 Message-ID: <54460.90500.904332.23993@gargle.gargle.HOWL> References: <87ftjcaojz.fsf@gnus.org> <39771.36515.154463.23991@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60811"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , 37957@debbugs.gnu.org To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 19:22:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPsbv-000Fi2-5V for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 19:22:23 +0100 Original-Received: from localhost ([::1]:43238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPsbt-0004g4-2E for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 14:22:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49950) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPsbc-0004eB-Q8 for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 14:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPsba-0004aN-Ot for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 14:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42620) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPsba-0004YH-6U for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPsbZ-0001f5-WA for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 14:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Roland Winkler" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2019 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37957 X-GNU-PR-Package: emacs Original-Received: via spool by 37957-submit@debbugs.gnu.org id=B37957.15724597176377 (code B ref 37957); Wed, 30 Oct 2019 18:22:01 +0000 Original-Received: (at 37957) by debbugs.gnu.org; 30 Oct 2019 18:21:57 +0000 Original-Received: from localhost ([127.0.0.1]:51441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPsbV-0001en-0M for submit@debbugs.gnu.org; Wed, 30 Oct 2019 14:21:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPsbT-0001ec-TG for 37957@debbugs.gnu.org; Wed, 30 Oct 2019 14:21:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iPsbO-0003ro-Ng; Wed, 30 Oct 2019 14:21:50 -0400 Original-Received: from [2601:240:8300:d3d0:248b:bf11:be2e:5309] (port=45448 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1iPsbN-0003Yn-SU; Wed, 30 Oct 2019 14:21:50 -0400 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170433 Archived-At: On Wed Oct 30 2019 Richard Copley wrote: > On Tue, 29 Oct 2019 at 01:52, Roland Winkler wrote: > > Yet I guess that enable-local-variables being nil may break more > > things if hack-local-variables-hook is not called. >=20 > Did you have something in mind? I don't see how it might break > anything for BibTeX mode. If it breaks something elsewhere, that > is a separate bug. I was thinking of other packages using hack-local-variables-hook. Yet I just checked that for the packages distributed with emacs, this hook appears to be not overly popular. So maybe my worries are not justified. > > If nothing else, we could mention in the docstring of > > hack-local-variables-hook that this hook is not called if > > enable-local-variables is nil. >=20 > Perhaps, but it is clear from the existing docstring ("[...] run after > processing a file=E2=80=99s local variables specs"), in my opinion. When I added bibtex-set-dialect to hack-local-variables-hook, I did not even anticipate the existence of a user variable enable-local-variables that could make this patch go wrong. I see no damage if this point gets mentioned in the docstring of hack-local-variables-hook. Roland