From: "Roland Winkler" <winkler@gnu.org>
To: Richard Copley <rcopley@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 37957@debbugs.gnu.org
Subject: bug#37957: BibTeX dialect not set if local variables disabled
Date: Wed, 30 Oct 2019 13:21:48 -0500 [thread overview]
Message-ID: <54460.90500.904332.23993@gargle.gargle.HOWL> (raw)
In-Reply-To: <CAPM58ognRDo0HZH8OPjKdW0Y3+hPYGprpuF84BAUMoNp5kqDHg@mail.gmail.com>
On Wed Oct 30 2019 Richard Copley wrote:
> On Tue, 29 Oct 2019 at 01:52, Roland Winkler <winkler@gnu.org> wrote:
> > Yet I guess that enable-local-variables being nil may break more
> > things if hack-local-variables-hook is not called.
>
> Did you have something in mind? I don't see how it might break
> anything for BibTeX mode. If it breaks something elsewhere, that
> is a separate bug.
I was thinking of other packages using hack-local-variables-hook.
Yet I just checked that for the packages distributed with emacs,
this hook appears to be not overly popular. So maybe my worries are
not justified.
> > If nothing else, we could mention in the docstring of
> > hack-local-variables-hook that this hook is not called if
> > enable-local-variables is nil.
>
> Perhaps, but it is clear from the existing docstring ("[...] run after
> processing a file’s local variables specs"), in my opinion.
When I added bibtex-set-dialect to hack-local-variables-hook, I did
not even anticipate the existence of a user variable
enable-local-variables that could make this patch go wrong. I see
no damage if this point gets mentioned in the docstring of
hack-local-variables-hook.
Roland
next prev parent reply other threads:[~2019-10-30 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 9:44 bug#37957: BibTeX dialect not set if local variables disabled Richard Copley
2019-10-28 15:16 ` Lars Ingebrigtsen
[not found] ` <CAPM58og0EX6F9vpVfq4fnVK-QWevXYUccf5_W_QbTLZ=iGxDuQ@mail.gmail.com>
2019-10-28 16:21 ` Lars Ingebrigtsen
2019-10-28 16:33 ` Richard Copley
2019-10-28 16:42 ` Lars Ingebrigtsen
2019-10-28 17:55 ` Richard Copley
2019-10-29 11:24 ` Lars Ingebrigtsen
2019-10-28 18:54 ` Eli Zaretskii
2019-10-29 1:52 ` Roland Winkler
2019-10-30 16:32 ` Richard Copley
2019-10-30 18:21 ` Roland Winkler [this message]
2020-12-02 19:54 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54460.90500.904332.23993@gargle.gargle.HOWL \
--to=winkler@gnu.org \
--cc=37957@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.