Problems with emacs 25 (master branch)

Problems with emacs 25 (master branch)

[Cédric Chépied]

Hi,

I updated my master branch yesterday and this morning I got some bad surprises.

I can't open my org agenda anymore (diary is retrieved with tramp):
  Tramp: Inserting `/ssh:*************/.diary'...done
  diary-list-entries: Symbol's function definition is void: fancy-diary-display

And then it just displays:
  Week-agenda (W41):
In the *Org Agenda* buffer

Newsticker also has problems:
  if: Symbol's value as variable is void: newsticker--download-logos [2 times]
It does not display any images anymore (I'm using w3m as HTML renderer). This is
very annoying for news which are only images:
  http://piratesourcil.blogspot.com/feeds/posts/default ).
I can open the news in w3m and see images.

Are my problems bugs or just configuration problems?

Thanks,
-- 
Cédric Chépied
<cedric.chepied@gmail.com>

Re: Problems with emacs 25 (master branch)

[Tassilo Horn]

Cédric Chépied <cedric.chepied@gmail.com> writes:

Hi Cédric,

> I updated my master branch yesterday and this morning I got some bad
> surprises.
>
> I can't open my org agenda anymore (diary is retrieved with tramp):
>   Tramp: Inserting `/ssh:*************/.diary'...done
>   diary-list-entries: Symbol's function definition is void: fancy-diary-display
>
> And then it just displays:
>   Week-agenda (W41):
> In the *Org Agenda* buffer

It seems `fancy-diary-display' has been renamed to
`diary-fancy-display'.  In your config, you probably have

  (setq diary-display-function 'fancy-diary-display)

and now you need to use

  (setq diary-display-function 'diary-fancy-display)

Or even better, you can just delete it from your configuration since
that's the default value with Emacs 25.

> Newsticker also has problems:
>   if: Symbol's value as variable is void: newsticker--download-logos [2 times]
> It does not display any images anymore (I'm using w3m as HTML renderer). This is

In the current newsticker.el there's no `newsticker--download-logos'
variable.  Probably that has been renamed to
`newsticker-download-images'.  However, setting a non-existent variable
in your config won't have any effects, so I'm not sure if it's your
fault or it is wrong in the emacs version you are using.  At least the
current newsticker.el looks correct.

What you can do is M-x toggle-debug-on-error RET and reproduce the error
above.  That will show a buffer with a backtrace which you can post
here.

Bye,
Tassilo

Re: Problems with emacs 25 (master branch)

[Thierry Volpiatto]

Tassilo Horn <tsdh@gnu.org> writes:

>
> It seems `fancy-diary-display' has been renamed to
> `diary-fancy-display'.  In your config, you probably have
>
>   (setq diary-display-function 'fancy-diary-display)
>
> and now you need to use
>
>   (setq diary-display-function 'diary-fancy-display)
>
> Or even better, you can just delete it from your configuration since
> that's the default value with Emacs 25.

Org in emacs-25 is still using `fancy-diary-display', see the function
`org-get-entries-from-diary' and because the alias have been removed,
org-agenda is broken...

So this is a bug in `org-get-entries-from-diary'.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: Problems with emacs 25 (master branch)

[Cédric Chépied]

At Fri, 10 Oct 2014 14:41:19 +0200,
Thierry Volpiatto wrote:
> 
> Org in emacs-25 is still using `fancy-diary-display', see the function
> `org-get-entries-from-diary' and because the alias have been removed,
> org-agenda is broken...
> 
> So this is a bug in `org-get-entries-from-diary'.

You are right, there is no reference to fancy-diary-display in my configuration


Tassilo Horn <tsdh@gnu.org> wrote:
>
> In the current newsticker.el there's no `newsticker--download-logos'
> variable.  Probably that has been renamed to
> `newsticker-download-images'.  However, setting a non-existent variable
> in your config won't have any effects, so I'm not sure if it's your
> fault or it is wrong in the emacs version you are using.  At least the
> current newsticker.el looks correct.

I found the problem in my configuration and logos are now downloaded without
error. But newsticker still doesn't display images inside news. I tried to
customize newsticker group but I couldn't find something related to this.

-- 
Cédric Chépied
<cedric.chepied@gmail.com>

Re: Problems with emacs 25 (master branch)

[Tassilo Horn]

Cédric Chépied <cedric.chepied@gmail.com> writes:

>> In the current newsticker.el there's no `newsticker--download-logos'
>> variable.  Probably that has been renamed to
>> `newsticker-download-images'.  However, setting a non-existent
>> variable in your config won't have any effects, so I'm not sure if
>> it's your fault or it is wrong in the emacs version you are using.
>> At least the current newsticker.el looks correct.
>
> I found the problem in my configuration and logos are now downloaded
> without error.  But newsticker still doesn't display images inside
> news.  I tried to customize newsticker group but I couldn't find
> something related to this.

Sorry, I actually don't use newsticker.el so I'm of no help here.

Bye,
Tassilo

Re: Problems with emacs 25 (master branch)

[Marco Wahl]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> Tassilo Horn <tsdh@gnu.org> writes:
>
>>
>> It seems `fancy-diary-display' has been renamed to
>> `diary-fancy-display'.  In your config, you probably have
>>
>>   (setq diary-display-function 'fancy-diary-display)
>>
>> and now you need to use
>>
>>   (setq diary-display-function 'diary-fancy-display)
>>
>> Or even better, you can just delete it from your configuration since
>> that's the default value with Emacs 25.
>
> Org in emacs-25 is still using `fancy-diary-display', see the function
> `org-get-entries-from-diary' and because the alias have been removed,
> org-agenda is broken...
>
> So this is a bug in `org-get-entries-from-diary'.

Thanks for the hint.  I will propose a corresponding patch to the Org list.

Concretely:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index da7993c..5fd9fbc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5112,8 +5112,10 @@ of what a project is and how to check if it stuck, customize the variable
   "Get the (Emacs Calendar) diary entries for DATE."
   (require 'diary-lib)
   (let* ((diary-fancy-buffer "*temporary-fancy-diary-buffer*")
-	 (diary-display-hook '(fancy-diary-display))
-	 (diary-display-function 'fancy-diary-display)
+	 (diary-display-function (if (version< emacs-version "25")
+				     'fancy-diary-display
+				   'diary-fancy-display))
+	 (diary-display-hook '(diary-display-function))
 	 (pop-up-frames nil)
 	 (diary-list-entries-hook
 	  (cons 'org-diary-default-entry diary-list-entries-hook))
--8<---------------cut here---------------end--------------->8---


Ciao,  Marco
-- 
http://www.wahlzone.de
PGP: 0x0A3AE6F2

Re: Problems with emacs 25 (master branch)

[Michael Heerdegen]

Marco Wahl <marcowahlsoft@gmail.com> writes:

> > So this is a bug in `org-get-entries-from-diary'.
>
> Thanks for the hint.  I will propose a corresponding patch to the Org
> list.

Please note that I had opened a bug about this, bug#18663.  Please let
me know when this issue has been fixed. Thanks.

Michael.

Re: Problems with emacs 25 (master branch)

[Ulf Jasper]

Cédric Chépied <cedric.chepied@gmail.com> writes:

> I found the problem in my configuration and logos are now downloaded without
> error. But newsticker still doesn't display images inside news. I tried to
> customize newsticker group but I couldn't find something related to this.

I cannot reproduce that with 

   newsticker-html-renderer is a variable defined in `newst-reader.el'.
   Its value is w3m-region

Could you please provide a recipe for reproducing, starting from
'emacs-Q'.

Re: Problems with emacs 25 (master branch)

[Marco Wahl]

Michael Heerdegen <michael_heerdegen@web.de> writes:
>> > So this is a bug in `org-get-entries-from-diary'.
>>
>> Thanks for the hint.  I will propose a corresponding patch to the Org
>> list.
>
> Please note that I had opened a bug about this, bug#18663.  Please let
> me know when this issue has been fixed. Thanks.

I will tell you off list.


Ciao,  Marco
-- 
http://www.wahlzone.de
GPG: 0x0A3AE6F2

Re: Problems with emacs 25 (master branch)

[Cédric Chépied]

At Fri, 10 Oct 2014 22:23:01 +0200,
Ulf Jasper wrote:
> Could you please provide a recipe for reproducing, starting from
> 'emacs-Q'.

With emacs -Q it works so there is no bug.
The problem was w3m-image-no-idle-timer which was set to t. I did this because
it used to stop downloading big images when in newsticker. Now it seems to work,
even with big images.

Thanks for the help.
-- 
Cédric Chépied
<cedric.chepied@gmail.com>

Re: Problems with emacs 25 (master branch)

[Cédric Chépied]

At Fri, 10 Oct 2014 18:13:50 +0200,
Michael Heerdegen wrote:
> Please note that I had opened a bug about this, bug#18663.  Please let
> me know when this issue has been fixed. Thanks.

I did a rebase this morning and it looks to be fixed.
-- 
Cédric Chépied
<cedric.chepied@gmail.com>

Re: Problems with emacs 25 (master branch)

[Michael Heerdegen]

Cédric Chépied <cedric.chepied@gmail.com> writes:

> I did a rebase this morning and it looks to be fixed.

Looks good, I closed the report.  Thanks!

Michael.