From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Leo Liu <sdl.web@gmail.com>, 18643@debbugs.gnu.org
Subject: bug#18643: 25.0.50; elisp--expect-function-p
Date: Sat, 11 Oct 2014 21:07:57 +0400 [thread overview]
Message-ID: <543963ED.2030107@yandex.ru> (raw)
In-Reply-To: <jwv4mvc9j20.fsf-monnier+emacsbugs@gnu.org>
On 10/10/2014 05:20 PM, Stefan Monnier wrote:
>> Now I just have to wrap my head around `elisp--local-variables'. :)
>
> It's very simple:
:)
> It takes the string between the first opening paren and point, appends
> a special symbol (the witness) followed by the number of missing closing
> parens to make the whole string a valid sexp, than reads¯oexpands
> that. And then we traverse the expanded code (a tree) straight from the
> root to the leaf corresponding to point (which is done in
> elisp--local-variables-1), collecting various info along the way.
Thanks!
I guess it might fail if some macros along the way require more
arguments than we actually give them. But that can be worked around on
case-by-case basis.
> Of course, traversing the tree efficiently is hard/impossible because
> we don't know for sure where is the witness (which represents point) in
> the tree, so we'd have to go through all the nodes of the tree, whereas
> we want to limit ourselves to going down from the root straight to the
> right leaf without backtracking.
I can see how performance could be a problem, but so far it's never been
the bottleneck for me. In the cases I measured, (lisp--local-variables)
takes around 1-2 ms (and up to 10ms near the end of the huge
`cl--parse-loop-clause').
So even the caching mechanism you have in
`lisp--local-variables-completion-table' could be unnecessary.
On the other hand, I've managed to find a specific case when it fails
(will file the bug shortly).
next prev parent reply other threads:[~2014-10-11 17:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 5:13 bug#18643: 25.0.50; elisp--expect-function-p Leo Liu
2014-10-09 2:50 ` Dmitry Gutov
2014-10-09 3:31 ` Leo Liu
2014-10-09 6:17 ` Dmitry Gutov
2014-10-09 15:27 ` Stefan Monnier
2014-10-09 23:43 ` Leo Liu
2014-10-10 1:16 ` Stefan Monnier
2014-10-10 4:07 ` Leo Liu
2014-10-10 13:25 ` Stefan Monnier
2014-10-10 20:53 ` Dmitry Gutov
2014-10-11 0:25 ` Leo Liu
2014-10-11 13:48 ` Stefan Monnier
2014-10-11 14:21 ` Leo Liu
2014-10-14 18:32 ` Stefan Monnier
2014-10-16 2:42 ` Dmitry Gutov
2014-10-16 13:10 ` Stefan Monnier
2014-10-11 13:47 ` Stefan Monnier
2014-10-11 16:18 ` Dmitry Gutov
2014-10-14 18:34 ` Stefan Monnier
2014-10-16 2:35 ` Dmitry Gutov
2014-10-16 3:36 ` Leo Liu
2014-10-16 9:59 ` Dmitry Gutov
2014-10-11 0:16 ` Leo Liu
2014-10-10 3:56 ` Dmitry Gutov
2014-10-10 4:33 ` Leo Liu
2014-10-11 16:31 ` Dmitry Gutov
2014-10-10 3:34 ` Dmitry Gutov
2014-10-10 13:20 ` Stefan Monnier
2014-10-11 17:07 ` Dmitry Gutov [this message]
2022-04-26 13:44 ` Lars Ingebrigtsen
2022-04-26 15:46 ` Leo Liu
2022-04-27 11:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543963ED.2030107@yandex.ru \
--to=dgutov@yandex.ru \
--cc=18643@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.