From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Leo Liu <sdl.web@gmail.com>
Cc: 18643@debbugs.gnu.org
Subject: bug#18643: 25.0.50; elisp--expect-function-p
Date: Fri, 10 Oct 2014 07:34:04 +0400 [thread overview]
Message-ID: <543753AC.3090604@yandex.ru> (raw)
In-Reply-To: <jwv1tqhffaf.fsf-monnier+emacsbugs@gnu.org>
On 10/09/2014 07:27 PM, Stefan Monnier wrote:
> I mean, Elisp completion has been context-sensitive "for ever", so the
> change is not that it now is, but that it now reacts to the
> context differently.
It completed against "all available symbols" in way too many situations.
And the logic was even simpler before 24.4, where IIRC you adopted some
code from company-elisp (and also reimplemented some).
> I think this is not right: we should have a elisp--expect-exp-p
> which returns non-nil in a context where we know the symbol at point
> should be a valid expression (i.e. a variable).
Yes, I guess it would make more sense (this function can whitelist
certain cases, like function name in a defun, for example).
> Not sure how to write
> it, tho, but in its absence I think we're better off completing against
> "anything" than restricting ourselves to variables.
Emacs 25.1 is probably still far away enough for us to get this right.
No need to revert useful changes.
> BTW, to improve on these behaviors, one approach is to take the
> macro-expansion code used in elisp--local-variables and use it
> "everywhere". I.e. expand elisp--local-variables so it doesn't just
> return the list of local vars, but also returns whether we're inside
> a quote, or we're expecting a function, or we're expecting an expression.
I'm glad that you think this approach will work. Sounds like then the
code will just have to handle a fixed number of forms, which is solvable.
Now I just have to wrap my head around `elisp--local-variables'. :)
next prev parent reply other threads:[~2014-10-10 3:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 5:13 bug#18643: 25.0.50; elisp--expect-function-p Leo Liu
2014-10-09 2:50 ` Dmitry Gutov
2014-10-09 3:31 ` Leo Liu
2014-10-09 6:17 ` Dmitry Gutov
2014-10-09 15:27 ` Stefan Monnier
2014-10-09 23:43 ` Leo Liu
2014-10-10 1:16 ` Stefan Monnier
2014-10-10 4:07 ` Leo Liu
2014-10-10 13:25 ` Stefan Monnier
2014-10-10 20:53 ` Dmitry Gutov
2014-10-11 0:25 ` Leo Liu
2014-10-11 13:48 ` Stefan Monnier
2014-10-11 14:21 ` Leo Liu
2014-10-14 18:32 ` Stefan Monnier
2014-10-16 2:42 ` Dmitry Gutov
2014-10-16 13:10 ` Stefan Monnier
2014-10-11 13:47 ` Stefan Monnier
2014-10-11 16:18 ` Dmitry Gutov
2014-10-14 18:34 ` Stefan Monnier
2014-10-16 2:35 ` Dmitry Gutov
2014-10-16 3:36 ` Leo Liu
2014-10-16 9:59 ` Dmitry Gutov
2014-10-11 0:16 ` Leo Liu
2014-10-10 3:56 ` Dmitry Gutov
2014-10-10 4:33 ` Leo Liu
2014-10-11 16:31 ` Dmitry Gutov
2014-10-10 3:34 ` Dmitry Gutov [this message]
2014-10-10 13:20 ` Stefan Monnier
2014-10-11 17:07 ` Dmitry Gutov
2022-04-26 13:44 ` Lars Ingebrigtsen
2022-04-26 15:46 ` Leo Liu
2022-04-27 11:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543753AC.3090604@yandex.ru \
--to=dgutov@yandex.ru \
--cc=18643@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.