From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18649-done@debbugs.gnu.org
Subject: bug#18649: 25.0.50; Closing TTY menus on MS-Windows
Date: Wed, 08 Oct 2014 15:35:31 +0200 [thread overview]
Message-ID: <54353DA3.8020202@gmx.at> (raw)
In-Reply-To: <83fveyk9pa.fsf@gnu.org>
>> BTW: Is there a way to turn `blink-cursor-mode' off on a TTY?
>
> No, it blinks "in hardware" (i.e., the terminal software does it).
> And there's no reason to disable it, because it should never do
> anything on a TTY. Or do you have evidence to the contrary?
No. I just wondered why the cursor disappeared (as Dani also observed)
when doing C-g with an open menu.
> It wasn't an old bug, it was indeed caused by the pixel-wise changes.
> Specifically, the fact that as part of the call to change_frame_size,
> we can now call Lisp (in frame_windows_min_size).
But this is not new, change_frame_size called resize_frame_windows,
which called Lisp before.
> The other part of
> the puzzle is that w32_console_read_socket calls change_frame_size
> unconditionally on every event it reads, because Windows doesn't tell
> us about resizes of the console window.
>
> So what happened was that we read the C-g key, called
> kbd_buffer_store_event for it, which set Vquit_flag, and then we
> called change_frame_size, which did QUIT when frame_windows_min_size
> called Lisp.
Ah, I seem to understand. resize_frame_windows never gets called here
because the size of the root window apparently doesn't change. OTOH
frame_windows_min_size gets called unconditionally. So it's merely
coincidental that this problem didn't hit us before.
BTW, I call frame_windows_min_size unconditionally in order to detect
the case where
(1) the frame size itself should be conceptually left unchanged, but
(2) something _within_ the frame changes (like adding a tool or scroll
bar) which requires a larger frame size to keep all windows of the
frame visible.
All this is unnecessary on TTYs.
> I fixed that by passing a non-zero DELAY argument to
> change_frame_size, so that it delays the actual resize to the next
> opportunity, like the next redisplay cycle.
Works here.
> I'm closing this bug.
Many thanks, martin
next prev parent reply other threads:[~2014-10-08 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 6:50 bug#18649: 25.0.50; Closing TTY menus on MS-Windows Dani Moncayo
2014-10-07 15:46 ` Eli Zaretskii
2014-10-07 19:58 ` Eli Zaretskii
2014-10-08 9:32 ` martin rudalics
2014-10-08 10:29 ` Eli Zaretskii
2014-10-08 12:49 ` Eli Zaretskii
2014-10-08 13:13 ` Dani Moncayo
2014-10-08 13:35 ` martin rudalics [this message]
2014-10-08 13:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54353DA3.8020202@gmx.at \
--to=rudalics@gmx.at \
--cc=18649-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.