From: Dmitry Antipov <dmantipov@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Stack-allocated objects again (+benchmark)
Date: Tue, 30 Sep 2014 12:25:48 +0400 [thread overview]
Message-ID: <542A690C.7050902@yandex.ru> (raw)
In-Reply-To: <542A18E8.9030601@cs.ucla.edu>
On 09/30/2014 06:43 AM, Paul Eggert wrote:
> Thanks for doing that, and for the benchmark. I found a couple of problems with
>< the patch, and thought of some ways to simplify it further and make it more portable
> and a bit faster in many cases, and installed that as trunk bzr 117978. Please have
> a look when you have the time.
1) Thanks, I like an idea with SCOPED_STRING without an extra allocation and memcpy.
2) This snippet from lisp.h:
4597 /* USE_STACK_LISP_OBJECTS requires GC_MARK_STACK == GC_MAKE_GCPROS_NOOPS. */
4598
4599 #if GC_MARK_STACK != GC_MAKE_GCPROS_NOOPS
4600 # undef USE_STACK_LISP_OBJECTS
4601 # define USE_STACK_LISP_OBJECTS false
4602 #endif
conflicts with alloc.c:
72 #if USE_STACK_LISP_OBJECTS
73 # if GC_MARK_STACK != GC_MAKE_GCPROS_NOOPS
74 # error "Stack-allocated Lisp objects are not compatible with GCPROs"
75 # endif
76 #endif
If you prefer 1st (I'm OK with that), 2nd one should be removed.
Dmitry
next prev parent reply other threads:[~2014-09-30 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 7:09 Stack-allocated objects again (+benchmark) Dmitry Antipov
2014-09-30 2:43 ` Paul Eggert
2014-09-30 8:25 ` Dmitry Antipov [this message]
2014-09-30 20:19 ` Paul Eggert
2014-09-30 14:05 ` Eli Zaretskii
2014-09-30 15:37 ` Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A690C.7050902@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.