From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18579: 24.3.93; vc-bzr-after-dir-status should not skip ignored files Date: Tue, 30 Sep 2014 05:23:24 +0400 Message-ID: <542A060C.90102@yandex.ru> References: <86vbo7wfsc.fsf@yandex.ru> <5429E5C0.6080902@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1412040281 32160 80.91.229.3 (30 Sep 2014 01:24:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2014 01:24:41 +0000 (UTC) Cc: 18579@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 03:24:34 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYmB7-0000SV-KQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 03:24:33 +0200 Original-Received: from localhost ([::1]:39968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYmB6-0001ka-Ev for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Sep 2014 21:24:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYmAw-0001kM-AE for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 21:24:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYmAh-000203-KS for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 21:24:22 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYmAh-0001zl-H2 for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 21:24:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYmAb-00081n-QC for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 21:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Sep 2014 01:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18579 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18579-submit@debbugs.gnu.org id=B18579.141204021030819 (code B ref 18579); Tue, 30 Sep 2014 01:24:01 +0000 Original-Received: (at 18579) by debbugs.gnu.org; 30 Sep 2014 01:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:55670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYmA5-000810-Dc for submit@debbugs.gnu.org; Mon, 29 Sep 2014 21:23:29 -0400 Original-Received: from mail-la0-f45.google.com ([209.85.215.45]:47625) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYmA3-00080r-5Z for 18579@debbugs.gnu.org; Mon, 29 Sep 2014 21:23:28 -0400 Original-Received: by mail-la0-f45.google.com with SMTP id q1so7607856lam.18 for <18579@debbugs.gnu.org>; Mon, 29 Sep 2014 18:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=P5MbkhXGO/akBqhCR2CPGfE8fmGblVv+/GZ4TtBf+xo=; b=UnKTJ+GaPoDDmXXiBhKLeF+x5k5QU9xWC9hjtZrRHDR0+35czh/o5RJ6KsTHzSlv0b OtjJTETNjN5DcGXTtqnnL2I/Dh5FE7pLQTU44uLa8uYLSHh44uYojxmbXXkbHteUfsr3 b/6cX8Q/SiT0z85ClCVyC7ouPGKQuPqrohONIAzJV7fzfM8oOSMpefiBsPrueQktw4Py sGhCu9B7QcQkQedoB+2LM8ObtcgwtKKlS+wnxuxdUa/2PGvGj9egjWfGccLhCREvZzQg FtiPf7faW4ExiJ4hvWtGG2qFeNN5h2KyHHD+Au7aH50xkbN/LLdNL2RiV2Tnmrag9EyQ BIkg== X-Received: by 10.112.146.1 with SMTP id sy1mr39980313lbb.77.1412040206176; Mon, 29 Sep 2014 18:23:26 -0700 (PDT) Original-Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id g18sm5464861lbo.41.2014.09.29.18.23.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 18:23:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93890 Archived-At: On 09/30/2014 04:34 AM, Stefan Monnier wrote: > I guess it's OK to return `ignored' files, but I don't think the API > should require it. E.g. for vc-cvs.el it's pretty difficult to list the > ignored files, IIRC. I think that's ok, we should understand that not all backend implementations are perfect. The API describes the ideal, and also how functions differ from each other. Mentioning `ignored' in `dir-status-files' description is useful, because it should include ignored files (if possible), whereas `dir-status', a quite similar command otherwise, is allowed to omit up-to-date and ignored files (probably should even be recommended to omit them, for performance reasons). And shouldn't vc-cvs.el implementation be able to use the trick you described earlier, and assign the status `ignored' to all files whose status it didn't find?