From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Philip Kaludercic <philipk@posteo.net>,
Lynn Winebarger <owinebar@gmail.com>,
Matthew Trzcinski <matt@excalamus.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [elpa] externals/org 26ef5e3e5b: org-src: Use `sh-mode' for all the shells it can handle
Date: Tue, 18 Apr 2023 11:50:57 +0200 [thread overview]
Message-ID: <54278F0A-B714-4DBB-8A63-8852046D32F6@acm.org> (raw)
In-Reply-To: <jwv1qkigtom.fsf-monnier+emacs@gnu.org>
17 apr. 2023 kl. 22.08 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>> I wouldn't mind adding `list*` at all. (It would eventually compile to list + nconc, of course.)
>
> I was thinking of adding it as a C-implemented function.
> It might still lose to list+nconc unless we also give it a bytecode, tho.
I think it would, but it's easy enough to find out, and we can change our minds later. I would go for a Lisp implementation, with special attention in codegen.
One thing that matters is what normal form to use during compilation, to make transforms manageable. I'm leaning towards representing `list*` as chained `cons` calls, since the other way around (represent `cons` as `list*`) would be more work for little benefit.
On the other hand it's good to avoid bad complexity and stack overflows for long list* calls (or long backquote lists). Philip, you wrote earlier:
> I have had issues in the past with ,@ expanding to code that would have
> exceeded the maximal evaluation depth, until I split it up and manually
> used `append' that has the advantage of being implemented in C.
Could you give us a representative example of the code that you had to split up? Did the max-eval-lisp-depth limit hit interpretation or compilation?
next prev parent reply other threads:[~2023-04-18 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168174708495.14139.12756054653439048176@vcs2.savannah.gnu.org>
[not found] ` <20230417155805.3E200C1391A@vcs2.savannah.gnu.org>
2023-04-17 16:08 ` [elpa] externals/org 26ef5e3e5b: org-src: Use `sh-mode' for all the shells it can handle Stefan Monnier
2023-04-17 16:16 ` Lynn Winebarger
2023-04-17 16:27 ` Philip Kaludercic
2023-04-17 16:37 ` Andreas Schwab
2023-04-17 16:42 ` Philip Kaludercic
2023-04-17 16:39 ` Mattias Engdegård
2023-04-17 16:47 ` Mattias Engdegård
2023-04-17 17:37 ` Stefan Monnier
2023-04-17 18:33 ` Mattias Engdegård
2023-04-17 20:08 ` Stefan Monnier
2023-04-18 9:50 ` Mattias Engdegård [this message]
2023-04-17 17:11 ` Stefan Monnier
2023-04-17 17:24 ` Lynn Winebarger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54278F0A-B714-4DBB-8A63-8852046D32F6@acm.org \
--to=mattiase@acm.org \
--cc=emacs-devel@gnu.org \
--cc=matt@excalamus.com \
--cc=monnier@iro.umontreal.ca \
--cc=owinebar@gmail.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.