From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18528: 24.3.93; Crash during restoration of frameset from desktop Date: Tue, 23 Sep 2014 07:48:40 +0200 Message-ID: <542109B8.6080107@gmx.at> References: <83egv3y90k.fsf@gnu.org> <54205FCF.4050503@gmx.at> <83bnq7y13y.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1411451440 3934 80.91.229.3 (23 Sep 2014 05:50:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Sep 2014 05:50:40 +0000 (UTC) Cc: 18528@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 23 07:50:32 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XWIzg-0006OV-9v for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Sep 2014 07:50:32 +0200 Original-Received: from localhost ([::1]:50799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWIzf-0005zy-Nn for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Sep 2014 01:50:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWIzR-0005zb-HB for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2014 01:50:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWIzH-00043B-Nz for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2014 01:50:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWIzH-0003wJ-Je for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2014 01:50:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XWIzB-0001QV-Uv for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2014 01:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Sep 2014 05:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18528 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14114513745443 (code B ref -1); Tue, 23 Sep 2014 05:50:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Sep 2014 05:49:34 +0000 Original-Received: from localhost ([127.0.0.1]:49348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWIyk-0001Pi-2R for submit@debbugs.gnu.org; Tue, 23 Sep 2014 01:49:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWIyg-0001PZ-29 for submit@debbugs.gnu.org; Tue, 23 Sep 2014 01:49:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWIyV-0003n4-Sr for submit@debbugs.gnu.org; Tue, 23 Sep 2014 01:49:29 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWIyV-0003mY-Pn for submit@debbugs.gnu.org; Tue, 23 Sep 2014 01:49:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWIyI-0005Xs-VG for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2014 01:49:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWIyB-0003lL-Fu for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2014 01:49:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:55636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWIy3-0003cv-EZ; Tue, 23 Sep 2014 01:48:51 -0400 Original-Received: from [188.22.234.109] ([188.22.234.109]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LvPgd-1YEonf45at-010ZSi; Tue, 23 Sep 2014 07:48:45 +0200 In-Reply-To: <83bnq7y13y.fsf@gnu.org> X-Provags-ID: V03:K0:NM8X9ItUwu2mSEZ7Y+OJ4mFA5o1PiVVCNOrbI0U/+aU5FKgOC7j uKpYxXwS4QemKeCJirNCOKR50yL5m/HMi0TmrRYzbA/2M53A3dU28tbP9stXH+tbsXCtb79 cZXRRjcrHPojZ/Zig85ajx2CYuFgXICTdf1Uw4jaR9RwPf1tqs+CrVjdyL6mhmcUXxydju6 0kI+i4WaSSyywaGjHe0zQ== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93652 Archived-At: > I certainly think so. If GetClientRect fails, how does it make sense > to use what we find in the rectangle data structure we passed to it? > The values there are just garbage. We have to check these values anyway because our window structure might be too complex to fit into the rectangle returned by GetClientRect. But then we should probably also rewrite things like w32_clear_window as if (hdc && GetClientRect (FRAME_W32_WINDOW (f), &rect)) w32_clear_rect (f, hdc, &rect); >> > + /* Recompute the dimensions in character units, since >> > + check_frame_size might have changed the pixel dimensions. */ >> > + /* Consider rounding here: Currently, the root window can be >> > + larger than the frame in terms of columns/lines. */ >> > + new_cols = new_text_width / FRAME_COLUMN_WIDTH (f); >> > + new_lines = new_text_height / FRAME_LINE_HEIGHT (f); I never got around to ask you: Do you anywhere see a need to round up the values of new_cols and new_lines in cases like this? martin