From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18116: 24.3.92; url-http calls CALLBACK recursively with malformed CBARGS if the former calls `delete-process' Date: Fri, 19 Sep 2014 06:00:07 +0400 Message-ID: <541B8E27.1060603@yandex.ru> References: <86ppgr4hqe.fsf@yandex.ru> <54110061.1060908@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1411092095 494 80.91.229.3 (19 Sep 2014 02:01:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Sep 2014 02:01:35 +0000 (UTC) Cc: 18116-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 19 04:01:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XUnVl-0001VP-TY for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Sep 2014 04:01:26 +0200 Original-Received: from localhost ([::1]:55416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUnVl-00074P-FE for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Sep 2014 22:01:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUnVb-00073S-NC for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 22:01:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUnVU-0001sn-6V for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 22:01:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUnVU-0001sX-3B for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 22:01:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XUnVO-0002Q6-TJ for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 22:01:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Sep 2014 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 18116@debbugs.gnu.org, dgutov@yandex.ru, dgutov@yandex.ru Original-Received: via spool by 18116-done@debbugs.gnu.org id=D18116.14110920159231 (code D ref 18116); Fri, 19 Sep 2014 02:01:02 +0000 Original-Received: (at 18116-done) by debbugs.gnu.org; 19 Sep 2014 02:00:15 +0000 Original-Received: from localhost ([127.0.0.1]:44978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUnUd-0002Oo-80 for submit@debbugs.gnu.org; Thu, 18 Sep 2014 22:00:15 -0400 Original-Received: from mail-la0-f50.google.com ([209.85.215.50]:38838) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUnUa-0002Og-TM for 18116-done@debbugs.gnu.org; Thu, 18 Sep 2014 22:00:13 -0400 Original-Received: by mail-la0-f50.google.com with SMTP id ty20so2269829lab.37 for <18116-done@debbugs.gnu.org>; Thu, 18 Sep 2014 19:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Y/pRKEt6pb6zHgL/z5mpvMPLZOePTb/RgLYOrP3qjGI=; b=OOva+pFDX7icMH1bCfcNV8DsmDpO7UqTmy5cmw+ExO77Zdf7Xo7NUT5YkvLaLa0pwO ESaJu1PKTna6vu/Fceb2VJYy1ut85CkvB9CSwWSg4p2yY5xhLar1IWVCK6PQi3dvxvTt cawSF2hGuUNA0Ux7v7l+Tnk+BYBeMCZtyMAJI9VTiMbh9E0x55baIgoCesvHRE+s1eat idso/P9gbYKSH3tg9Xf+2FW7oKTqJ5kU8x1Es1fRQR8vxRlHVCKSJI1Om4qG+ZjKUCf/ LiMoI/7Q4LpK980+VWTsVEkUqZVH5z9GAJVXvQc0BfaWDJ+J0UdJWyh8QyQ2P6XpmMav 5rwQ== X-Received: by 10.112.88.133 with SMTP id bg5mr3021765lbb.93.1411092011595; Thu, 18 Sep 2014 19:00:11 -0700 (PDT) Original-Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id qr9sm131726lbb.11.2014.09.18.19.00.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Sep 2014 19:00:10 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93496 Archived-At: Version: 24.3.93.4 On 09/12/2014 09:22 PM, Stefan Monnier wrote: > I think there is indeed a change of behavior in that the sentinel used > to be nil'd while running it. > [ This was changed because it prevented the sentinel from modifying itself. ] Okay, I guess. >> To me, "When retrieval is completed, execute the function CALLBACK, using >> the arguments listed in CBARGS." means that it will be called exactly with >> the value of CBARGS passed to `url-http', whereas instead the list gets >> prepended with stuff before it's passed to CALLBACK. > > Can you improve those docstrings, to avoid such confusion in the future? Done, I think (r117511). Although maybe we should remove the middle paragraph in `url-http' docstring and replace it with a reference to `url-retrieve-internal': its second sentence has very much the same contents, only using different words.