From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18451: 24.4.50; 'toggle-frame-fullscreen' can cut off minibuffer Date: Thu, 18 Sep 2014 14:41:34 +0200 Message-ID: <541AD2FE.4030002@gmx.at> References: <87mwa65dte.fsf@alarm.home> <65FD46C3-80B3-497B-B3B3-7010772CD56F@swipnet.se> <87vboum4cq.fsf@ixlun.home> <98621C9D-9606-42E4-AC57-02D6F6B30CD8@swipnet.se> <87vbori2yi.fsf@matt-desktop.home> <0264F34D-0837-401E-9215-C401BD62CF99@swipnet.se> <87oauitjiw.fsf@mattleach.net> <3ABE107B-3F0E-465A-908A-5943E493DDC0@swipnet.se> <87oaufe5pc.fsf@psy.home> <54195C33.3050409@gmx.at> <871trapm5d.fsf@psy.home> <541AA6C0.4070604@gmx.at> <877g11i1cp.fsf@matt-desktop.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1411044154 2761 80.91.229.3 (18 Sep 2014 12:42:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Sep 2014 12:42:34 +0000 (UTC) Cc: 18451@debbugs.gnu.org To: Matthew Leach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 18 14:42:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XUb2X-0000us-U2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Sep 2014 14:42:26 +0200 Original-Received: from localhost ([::1]:50436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUb2X-0000SH-KP for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Sep 2014 08:42:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUb2N-0000RG-EN for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 08:42:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUb2F-0004Xm-U0 for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 08:42:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUb2F-0004WD-Pr for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 08:42:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XUb2A-00011v-6q for bug-gnu-emacs@gnu.org; Thu, 18 Sep 2014 08:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Sep 2014 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18451-submit@debbugs.gnu.org id=B18451.14110441103933 (code B ref 18451); Thu, 18 Sep 2014 12:42:02 +0000 Original-Received: (at 18451) by debbugs.gnu.org; 18 Sep 2014 12:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:44037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUb1w-00011M-Tl for submit@debbugs.gnu.org; Thu, 18 Sep 2014 08:41:49 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:57905) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUb1t-00011D-BM for 18451@debbugs.gnu.org; Thu, 18 Sep 2014 08:41:46 -0400 Original-Received: from [188.22.237.86] ([188.22.237.86]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LaG7C-1YAqsM44iM-00m5zw; Thu, 18 Sep 2014 14:41:41 +0200 In-Reply-To: <877g11i1cp.fsf@matt-desktop.home> X-Provags-ID: V03:K0:Ulr5fV5vvXsvJUK1ofDkvsx1iE4S4AM8u/7Yz22EUPV9oC1FkOg d3IXaBWZ5r5/Z3P4Pe1hquQaWC3dK4YHbQsc99FxEJ3KzqlY7vHDE/nIHwui2QSrPL/cjM1 KI0R6fX6+90izqfTDYTlfVbpfn+ntSseKIcCvcQ0ebtlHH92AskyqGeSYdwi0LPkcVprf6K APdU9yE+Q25l8jdV8PpEw== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93464 Archived-At: >> Just for the record, even if you eval the form when startin Emacs? > > Actually, I hadn't done that, I just evaluated it in the scratch buffer. I would have done that in your place too ;-) > However, when I paste this as the first form in my .emacs it seems to > fix the issue! I've been toggling for about 10 minutes now and haven't > seen an occurrence of the bug. I'm afraid this issue is not only restricted to your window manager and not only to getting a fullscreen display. I've recently observed a similar problem when trying to always come up with the same frame height with plain emacs -Q on a Gtk build. On the average it fails every fourth time with three missing lines. It does not fail when I set `frame-resize-pixelwise' to a non-nil value. > Oops, configure_frame_size should be `change_frame_size' defined in > dispnew.c I should have figured that out. Where exactly is your trace point? Personally I prefer one in change_frame_size_1 where it says /* This size-change overrides any pending one for this frame. */ to avoid that a rescheduled change_frame_size appears in the trace but it certainly doesn't matter here. >> Are the traces here in chronological order or reversed? > > They are in chronological order. Good (it's not obvious from the trace alone). Still I miss things like change_frame_size(0x6896f8, 1350, 768, 0, 1, 0, 1); ConfigureNotify event received. ConfigureNotify event received. change_frame_size(0x6896f8, 1350, 768, 0, 0, 1, 1); ConfigureNotify event received. ConfigureNotify event received. ConfigureNotify event received. xg_frame_resized(0x6896f8, 679, 729); change_frame_size(0x6896f8, 663, 729, 0, 1, 0, 1); change_frame_size(0x6896f8, 663, 729, 0, 0, 0, 1); ConfigureNotify event received. ConfigureNotify event received. xg_frame_resized(0x6896f8, 672, 720); change_frame_size(0x6896f8, 656, 720, 0, 1, 0, 1); xg_frame_resized(0x6781b0, 1366, 768); configure_frame_size(0x6781b0, 1350, 768, 330584, 1, 0, 1); from your earlier trace where some height change seems visible. >> And how do you get a ConfigureNotify event for a frame `nil'? > > I'm not sure, but it seems to be expected behaviour as there is an > explicit test for it in the ConfigureNotify event handler. The frame is > set to `any' if x_top_window_to_frame returns null. Arrgh... I'm too silly. In any case, the problem could be due to the following: (1) Due to some non-textual settings (scroll bar, divider, border width) we ask the window manager for a frame height which is _not_ an integral multiple of the nominal character height. At the same time we ask the window manager to store that nominal height as the canonical height by which frame height change increments should be allowed. (2) The window manager (sometimes) decides that our resize request is impudent and overrules it by sending us a size that fits the nominal height settings. Jan is our hints expert. Maybe he has an idea. martin