From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-24 r117502: Always use matched specpdl entry to record call arguments (Bug#18473). Date: Tue, 16 Sep 2014 20:22:20 +0400 Message-ID: <541863BC.4010703@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1410884571 17269 80.91.229.3 (16 Sep 2014 16:22:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Sep 2014 16:22:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 16 18:22:45 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XTvWe-0006kd-Ms for ged-emacs-devel@m.gmane.org; Tue, 16 Sep 2014 18:22:44 +0200 Original-Received: from localhost ([::1]:39138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvWe-0001M0-1L for ged-emacs-devel@m.gmane.org; Tue, 16 Sep 2014 12:22:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvWU-0001EA-7o for emacs-devel@gnu.org; Tue, 16 Sep 2014 12:22:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTvWL-0006xM-Lj for emacs-devel@gnu.org; Tue, 16 Sep 2014 12:22:34 -0400 Original-Received: from forward2h.cmail.yandex.net ([87.250.230.17]:36333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvWL-0006ut-Ct for emacs-devel@gnu.org; Tue, 16 Sep 2014 12:22:25 -0400 Original-Received: from smtp2h.mail.yandex.net (smtp2h.mail.yandex.net [84.201.187.145]) by forward2h.cmail.yandex.net (Yandex) with ESMTP id EB44B1617; Tue, 16 Sep 2014 20:22:20 +0400 (MSK) Original-Received: from smtp2h.mail.yandex.net (localhost [127.0.0.1]) by smtp2h.mail.yandex.net (Yandex) with ESMTP id 9E1FD170585F; Tue, 16 Sep 2014 20:22:20 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp2h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id zCD9T2MDqi-MKjeFaTC; Tue, 16 Sep 2014 20:22:20 +0400 (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: 416e184b-9651-4ebe-b1db-cb2e4342887d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1410884540; bh=/UtQyj/mSY2TXuyoal6UmmH5nkE0GKOxhw/1N4YGZDw=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=VXZZrxeWWuS5hfEpeD+BMkchNzSBd/eFJziAB+N/RHuXvAu4eHdiHFSuD4gneyUjv 9/ToMUNv3HtuaFyMrnAEJWuggmTVNYBJwBq2STPZdRnjLZ129jytM7YNIxYaHvKREk 9UbBCgWlILmTJL7e11kkLNuGClEuhgJ/0t9i/+Do= Authentication-Results: smtp2h.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 87.250.230.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174378 Archived-At: On 09/16/2014 06:13 PM, Stefan Monnier wrote: > This will slow down every single function call. Not by much, but > they're already pretty slow, so we should work hard not to make it worse. IMO if we really care about speed in eval_sub, we should redesign this first: 2111 if (SUBRP (fun)) 2112 { 2113 Lisp_Object numargs; 2114 Lisp_Object argvals[8]; 2115 Lisp_Object args_left; 2116 register int i, maxargs; 2117 2118 args_left = original_args; 2119 numargs = Flength (args_left); <-- bad Generic Flength is too slow due to monster if...else: 121 if (STRINGP (sequence)) 122 XSETFASTINT (val, SCHARS (sequence)); 123 else if (VECTORP (sequence)) 124 XSETFASTINT (val, ASIZE (sequence)); 125 else if (CHAR_TABLE_P (sequence)) 126 XSETFASTINT (val, MAX_CHAR); 127 else if (BOOL_VECTOR_P (sequence)) 128 XSETFASTINT (val, bool_vector_size (sequence)); 129 else if (COMPILEDP (sequence)) 130 XSETFASTINT (val, ASIZE (sequence) & PSEUDOVECTOR_SIZE_MASK); 131 else if (CONSP (sequence)) and we know that args_left is always a list. Dmitry