From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Hash values of symbols: why look at the name? Date: Mon, 15 Sep 2014 17:19:02 -0700 Message-ID: <541781F6.7010600@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6vP4PFcV2fD6VPWCh5pdrLuajEUjA47h1" X-Trace: ger.gmane.org 1410828747 31732 80.91.229.3 (16 Sep 2014 00:52:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Sep 2014 00:52:27 +0000 (UTC) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 16 02:52:22 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XTh0I-0005T2-55 for ged-emacs-devel@m.gmane.org; Tue, 16 Sep 2014 02:52:22 +0200 Original-Received: from localhost ([::1]:35204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTh0H-0005iW-QI for ged-emacs-devel@m.gmane.org; Mon, 15 Sep 2014 20:52:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTh06-0005hZ-7Q for emacs-devel@gnu.org; Mon, 15 Sep 2014 20:52:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTh05-0003Bk-7B for emacs-devel@gnu.org; Mon, 15 Sep 2014 20:52:10 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:48170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTh04-00039n-Sh for emacs-devel@gnu.org; Mon, 15 Sep 2014 20:52:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:Subject:To:MIME-Version:From:Date:Message-ID; bh=Pzy+pQ4g7xkCkZgON+0UtPLpqxOmf98s6Szc4vWAX+0=; b=MRpmlW9xv3a9ivi0NXG/HpMY+P2cdTVMLrNk1nYkE4NGJpvkUu7Wu5q/3yIP5Xdbv9qGglUc0l+SRW7OkpBxyPhKjBgYfsKdNQBvbrOmreLYVJn6R+MX1tFNqqUVtboLtEPwFjIZjDYjS69JwXS3XewMYlMFfiMltpBNSRMakU9zMOtDL0yh62RKOPvevMkS8nFKeTpgRjkx0NZlG776mAB3S37yohB1MRcl5/XvfPLqyjnuiCwIpbZDG2W9mltzdLtJe/pmtLna1Iu1PANwJaRiwzsrTBh7i4SSj3uYjtmnvl+Obm5Dc3/1a9qkI3/OrFUUsaWSOaOkiwYoilTtZg==; Original-Received: from [2620:10d:c083:1004:2b5:6dff:fe00:f9a6] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_RC2) (envelope-from ) id 1XTgU8-00026N-F9 for emacs-devel@gnu.org; Mon, 15 Sep 2014 17:19:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174346 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6vP4PFcV2fD6VPWCh5pdrLuajEUjA47h1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Right now, this form always evaluates to t: (eql (sxhash (make-symbol "a")) (sxhash (make-symbol "a"))) This form always evaluates to nil: (equal (make-symbol "a") (make-symbol "a")) The hash of a symbol is the hash of its namel; that seems silly, since symbol equality is based on identity. We should be able to just use the symbol address instead, right? =3D=3D=3D modified file 'src/fns.c' --- src/fns.c 2014-09-15 05:09:44 +0000 +++ src/fns.c 2014-09-16 00:14:52 +0000 @@ -4482,13 +4482,10 @@ break; case Lisp_Misc: + case Lisp_Symbol: hash =3D XHASH (obj); break; - case Lisp_Symbol: - obj =3D SYMBOL_NAME (obj); - /* Fall through. */ - case Lisp_String: hash =3D sxhash_string (SSDATA (obj), SBYTES (obj)); break; --6vP4PFcV2fD6VPWCh5pdrLuajEUjA47h1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJUF4H2AAoJEN4WImmbpWBluEAQAK2BQOrsJfo9sFr6je2yxEFo tzhfEyW8d1Sbil62M69Cv0xrGUG5nWRBCDuuyiSEtUDMZPwMTyX1ul+B/WqlUSSP qx/IYpy5hGAmieczS+TkW6v4rdK7Gg6BcLMEWlDDmxD156rj6MmMSIDOPaPfFac7 dD29FLcKQsdrsrzVwxpWgnFOsvYXnTN8J1AS16eaiA1FOqjwiCw2IgO7yu6MUewZ +njv2ZW7c9FBWfyBTww+kaA6TLGH0syFbJi8Sp6FbBelVX6u6iksTBjvGsyOkKmx K0DUra+EAE7SeiTvUNAJwTDmaNcX/X+6TAUIjak9mh1aJ/Ce51ElTU4MIPwr0Bn5 +vIZuUPY1fgjGM/vcLTHRfS+K0klMY4zk09TBq3if8Vdfn09zwq5tvYDTYJoDyB3 xNoGLsTvDwsG/LjPMs8waw8+ygX0eLs1xwZWzcZel+Cj5JQw+eql8hkBSEo9CfkG fQL7A291tSQslLOOXUOe1PeD0LmK73osX8RwmWFmeZ83oNVAJkec6UO40FMfvsTc WeVvrPKai5cxVdMekBx9ggzJqyXx+xchdgWOiae6YMwEFj5ZfQjGst0SGb5lHGda JDmxIJH7hDGjlIXj/ZUZlvG1OyqNkq8iG+7SLukyUimEfACCAZtpgDw8qJ2weN6F c45pIR++nGTFp2T3dUrU =mwpB -----END PGP SIGNATURE----- --6vP4PFcV2fD6VPWCh5pdrLuajEUjA47h1--