From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: New review conversion of Emacs repository Date: Sat, 13 Sep 2014 12:54:16 -0700 Organization: UCLA Computer Science Department Message-ID: <5414A0E8.2090502@cs.ucla.edu> References: <20140913135842.EDB543805BA@snark.thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1410638098 32196 80.91.229.3 (13 Sep 2014 19:54:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Sep 2014 19:54:58 +0000 (UTC) To: "Eric S. Raymond" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 13 21:54:51 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XStPG-00062M-Ie for ged-emacs-devel@m.gmane.org; Sat, 13 Sep 2014 21:54:50 +0200 Original-Received: from localhost ([::1]:51630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XStPG-0008Qq-4K for ged-emacs-devel@m.gmane.org; Sat, 13 Sep 2014 15:54:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XStOy-0008Qk-Ks for emacs-devel@gnu.org; Sat, 13 Sep 2014 15:54:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XStOo-000674-VJ for emacs-devel@gnu.org; Sat, 13 Sep 2014 15:54:32 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:59330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XStOo-00064G-Mr for emacs-devel@gnu.org; Sat, 13 Sep 2014 15:54:22 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 407EBA60018; Sat, 13 Sep 2014 12:54:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fYKOm5A2R8Br; Sat, 13 Sep 2014 12:54:16 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id CA8D8A60012; Sat, 13 Sep 2014 12:54:16 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 In-Reply-To: <20140913135842.EDB543805BA@snark.thyrsus.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174277 Archived-At: Thanks for doing that. As an example of how much faster 'git' is on my desktop, 'git log' takes 2 seconds, whereas 'bzr log' takes 28 seconds, with both repositories hot. I am looking forward to the switchover. I looked at the conversion and have some questions. Sorry, it's been so long since I reviewed the last conversion that I forgot whether these issues have come up before. (If they have, please just consider this as stuff that still worries me mildly. :-) * On the master/trunk branch, the git repository contains 549 commits more than the bzr repository does, 117867 versus 117318. I assume this is because the git repository lists each merged change separately rather than a single 'Merge from' commit. I wanted to confirm this, though. For example, git commit 94075d6f559ced1fab36c50bdfa51a612f422080 by Glenn Morris dated Sep 7 22:57:24 2014 -0700 isn't explictly mentioned in the bzr log, and was this because it was part of the bzr merge that produced trunk bzr 117839 dated 2014-09-07 23:00:58 -0700 by Glenn? Are there any other reasons a commit should appear in one log but not the other? * Rewriting revision numbers occasionally makes ChangeLog lines longer than 80 characters. I propose that we fix this via a manual pass after the change, something that's done fairly routinely for ChangeLog files anyway. * This conversion treats ChangeLog as metadata, and I'd feel more comfortable if ChangeLog files were treated as data. For example, if I ask the git repository "Please give me src/ChangeLog as the end of 2012", I git a different answer than if I ask the bzr repository the same question. (See the diff output below.) I'd feel more comfortable if these changes were applied to the ChangeLog files via the abovementioned pass after the conversion, as that way the old git data will match the old bzr data exactly. $ diff -u <(cd trunk && bzr cat -r111390 ChangeLog) \ <(cd review6 && git show \ 431e43b612777eefb6655728f7979a9c8d87c429:ChangeLog) --- /dev/fd/63 2014-09-13 11:26:24.254835175 -0700 +++ /dev/fd/62 2014-09-13 11:26:24.255835194 -0700 @@ -1122,7 +1122,7 @@ 2012-06-23 Eli Zaretskii - Fix the MS-Windows build broken by revno 108687. + Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu. * lib/makefile.w32-in (GNULIBOBJS): Add $(BLD)/dtotimespec.$(O), $(BLD)/gettime.$(O), $(BLD)/timespec-add.$(O), and $(BLD)/timespec-sub.$(O).