From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: srivasta@ieee.org, emacs-devel@gnu.org
Subject: Re: Trunk emacs infelicity with linum mode
Date: Thu, 11 Sep 2014 18:40:09 +0200 [thread overview]
Message-ID: <5411D069.5020007@gmx.at> (raw)
In-Reply-To: <83oaum8a0e.fsf@gnu.org>
>> > If I set a breakpoint in Fface_font, which is what barfed in the OP's
>> > case, the breakpoint doesn't break inside the call to
>> > adjust_frame_size or Fx_create_frame, it breaks after Fx_create_frame
>> > already returned. I don't know why the difference.
>>
>> I suppose the OP confused two calls of adjust_frame_size - the one at
>> line 4609 and the one at line 4678.
>
> Or maybe we confused that.
We won't be able to tell but among the values he posted we have an
old_text_width of 10 which is inherently incompatible with a call from
line 4678 and a frame column width of 9.
> Probably because of the tool bar or the scroll bars -- these are the
> only differences between the builds, AFAIR.
The tool bar is set before calling x_figure_window_size so I suspect
it's the scroll bar height call which in adjust_frame_size already sets
all values just as the change_frame_size callback triggered by the call
on line 4678 wants them. This would explain that the hook is _not_
triggered by the call on line 4678. It doesn't explain why it's
triggered on Motif/Lucid where I basically "do the same thing" (though
apparently I don't).
> What will break if we set f->official true only _after_ the second
> adjust_frame_size returns?
Nothing, I presume. More so, because the fact that the hook is not
triggered on Windows and Gtk, already constitutes a bug which makes the
use of the hook during frame setup impractical on these systems. Note,
however, that the hook might still trigger any time in between setting
f->official and executing
(face-set-after-frame-default frame parameters)
though currently I can't see how that could happen.
martin
next prev parent reply other threads:[~2014-09-11 16:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 17:22 Trunk emacs infelicity with linum mode Manoj Srivastava
2014-09-02 18:03 ` Eli Zaretskii
2014-09-02 18:56 ` Manoj Srivastava
2014-09-02 19:11 ` Eli Zaretskii
2014-09-03 7:06 ` Manoj Srivastava
2014-09-03 15:50 ` Eli Zaretskii
2014-09-03 16:28 ` Manoj Srivastava
2014-09-04 15:29 ` Eli Zaretskii
2014-09-04 15:56 ` Stefan Monnier
2014-09-04 18:37 ` Eli Zaretskii
2014-09-04 20:25 ` Stefan Monnier
2014-09-05 6:58 ` Eli Zaretskii
2014-09-05 15:23 ` Stefan Monnier
2014-09-05 15:32 ` Eli Zaretskii
2014-09-05 16:23 ` Stefan Monnier
2014-09-05 17:49 ` Eli Zaretskii
2014-09-06 1:19 ` Manoj Srivastava
2014-09-06 7:43 ` Eli Zaretskii
2014-09-06 15:23 ` Manoj Srivastava
2014-09-06 20:27 ` Stefan Monnier
2014-09-07 5:07 ` Manoj Srivastava
2014-09-08 0:28 ` Stefan Monnier
2014-09-05 18:48 ` Manoj Srivastava
2014-09-05 19:53 ` Eli Zaretskii
2014-09-06 8:52 ` martin rudalics
2014-09-06 11:18 ` martin rudalics
2014-09-07 15:24 ` Eli Zaretskii
2014-09-07 18:03 ` martin rudalics
2014-09-07 19:28 ` Eli Zaretskii
2014-09-08 9:31 ` martin rudalics
2014-09-07 18:09 ` martin rudalics
2014-09-07 19:34 ` Eli Zaretskii
2014-09-08 9:32 ` martin rudalics
2014-09-09 13:13 ` Eli Zaretskii
2014-09-10 8:03 ` martin rudalics
2014-09-10 17:39 ` Eli Zaretskii
2014-09-10 19:02 ` martin rudalics
2014-09-10 19:15 ` Eli Zaretskii
2014-09-10 19:25 ` Eli Zaretskii
2014-09-11 9:26 ` martin rudalics
2014-09-11 15:14 ` Eli Zaretskii
2014-09-11 16:40 ` martin rudalics [this message]
2014-09-11 16:53 ` Eli Zaretskii
2014-09-11 17:59 ` martin rudalics
2014-09-11 18:09 ` martin rudalics
2014-09-03 12:37 ` Herbert J. Skuhra
2014-09-03 15:31 ` Manoj Srivastava
2015-01-04 18:09 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411D069.5020007@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=srivasta@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.