bug#18419: [Regression] Line number missing when enabling linum-mode

bug#18419: [Regression] Line number missing when enabling linum-mode

[Ting-Yu Lin]

[-- Attachment #1.1: Type: text/plain, Size: 1431 bytes --]

I found a regression related to commit titled "Fix bug #17892 with
mode/header line and display margins."
https://github.com/emacs-mirror/emacs/commit/691d7ac6784

Steps to reproduce:
1. emacs -Q
2. Evaluate the following code to make the mini-buffer becomes multi-line.

;;
https://github.com/gempesaw/ido-vertical-mode.el/blob/master/ido-vertical-mode.el#L45
(setq ido-decorations
      '("\n-> " ; left bracket around prospect list
    "" ; right bracket around prospect list
    "\n " ; separator between prospects, depends on `ido-separator`
    "\n ..." ; inserted at the end of a truncated list of prospects
    "[" ; left bracket around common match string
    "]" ; right bracket around common match string
    " [No match]"
    " [Matched]"
    " [Not readable]"
    " [Too big]"
    " [Confirm]"
    "\n-> " ; left bracket around the sole remaining completion
    "" ; right bracket around the sole remaining completion
    ))
(ido-mode 1)
(global-linum-mode 1)

3. Open a large file such as src/dispextern.h in Emacs repository.
4. C-x C-f to find files (Notice the mini-buffer now becomes multi-line,
and push the mode-line up. See multi_line_mini_buffer.png as attached.)
5. C-g to quit (the mini-buffer has one line again)
6. The line number 30 disappear, and the content of the line shifts left a
little bit. (See line_30_missing.png) The line number at the area is always
missing even if you scroll the file down.

[-- Attachment #1.2: Type: text/html, Size: 1986 bytes --]

[-- Attachment #2: line_30_missing.png --]
[-- Type: image/png, Size: 297495 bytes --]

[-- Attachment #3: multi_line_mini_buffer.png --]
[-- Type: image/png, Size: 293592 bytes --]

bug#18418: [Regression] Line number missing when enabling linum-mode

[Eli Zaretskii]

> From: Ting-Yu Lin (林庭宇) <aethanyc@gmail.com>
> Date: Sun, 7 Sep 2014 00:02:51 +0800
> 
> I found a regression related to commit titled "Fix bug #17892 with
> mode/header line and display margins."
> https://github.com/emacs-mirror/emacs/commit/691d7ac6784

Sorry, I don't understand: are you saying the problem you describe
started appearing after that commit?

> 1. emacs -Q
> 2. Evaluate the following code to make the mini-buffer becomes
> multi-line.
> 
> ;;
> https://github.com/gempesaw/ido-vertical-mode.el/blob/master/ido-vertical-mode.el#L45
> (setq ido-decorations
> '("\n-> " ; left bracket around prospect list
> "" ; right bracket around prospect list
> "\n " ; separator between prospects, depends on `ido-separator`
> "\n ..." ; inserted at the end of a truncated list of prospects
> "[" ; left bracket around common match string
> "]" ; right bracket around common match string
> " [No match]"
> " [Matched]"
> " [Not readable]"
> " [Too big]"
> " [Confirm]"
> "\n-> " ; left bracket around the sole remaining completion
> "" ; right bracket around the sole remaining completion
> ))
> (ido-mode 1)
> (global-linum-mode 1)
> 
> 3. Open a large file such as src/dispextern.h in Emacs repository.
> 4. C-x C-f to find files (Notice the mini-buffer now becomes
> multi-line, and push the mode-line up. See multi_line_mini_buffer.png
> as attached.)
> 5. C-g to quit (the mini-buffer has one line again)
> 6. The line number 30 disappear, and the content of the line shifts
> left a little bit. (See line_30_missing.png) The line number at the
> area is always missing even if you scroll the file down.

Sorry, I cannot reproduce this here.  My line 30 is intact after the
above steps.

bug#18419: [Regression] Line number missing when enabling linum-mode

[martin rudalics]

 > Steps to reproduce:

The following scenario should be simpler:

1. emacs -Q
2. M-: (setq resize-mini-windows nil) RET
3. Open a file such as src/dispextern.h
4. M-x linum-mode
5. Mouse-drag the mode line up once and then down

My machine is too slow to make such dragging a reasonable exercise but
the gaps show up immediately here.  And for the record: `nlinum-mode'
suffers the same problem.

martin

bug#18419: [Regression] Line number missing when enabling linum-mode

[Eli Zaretskii]

> Date: Sun, 07 Sep 2014 11:02:14 +0200
> From: martin rudalics <rudalics@gmx.at>
> 
>  > Steps to reproduce:
> 
> The following scenario should be simpler:
> 
> 1. emacs -Q
> 2. M-: (setq resize-mini-windows nil) RET
> 3. Open a file such as src/dispextern.h
> 4. M-x linum-mode
> 5. Mouse-drag the mode line up once and then down

Thanks, I fixed this.

bug#18419: [Regression] Line number missing when enabling linum-mode

[Eli Zaretskii]

Fixed in r117484 on the emacs-24 branch.