From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18381: 24.3.93; Diary can wrongly be displayed in Calendar's window Date: Sat, 06 Sep 2014 10:52:25 +0200 Message-ID: <540ACB49.8010405@gmx.at> References: <87k35nqtdd.fsf@rosalinde.fritz.box> <54085AC5.5050304@gmx.at> <7lr3zrjm94.fsf@fencepost.gnu.org> <64a96fko3d.fsf@fencepost.gnu.org> <54099491.4040607@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1409993612 29477 80.91.229.3 (6 Sep 2014 08:53:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Sep 2014 08:53:32 +0000 (UTC) Cc: Stephen Berman , 18381@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 06 10:53:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XQBkH-0008Gg-M5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Sep 2014 10:53:21 +0200 Original-Received: from localhost ([::1]:33828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQBkH-0006Lc-C4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Sep 2014 04:53:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQBk7-0006Kg-4l for bug-gnu-emacs@gnu.org; Sat, 06 Sep 2014 04:53:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQBjz-0000RA-Bj for bug-gnu-emacs@gnu.org; Sat, 06 Sep 2014 04:53:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQBjz-0000R4-71 for bug-gnu-emacs@gnu.org; Sat, 06 Sep 2014 04:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XQBjy-0002xX-C6 for bug-gnu-emacs@gnu.org; Sat, 06 Sep 2014 04:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Sep 2014 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18381-submit@debbugs.gnu.org id=B18381.140999357111352 (code B ref 18381); Sat, 06 Sep 2014 08:53:02 +0000 Original-Received: (at 18381) by debbugs.gnu.org; 6 Sep 2014 08:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:60316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQBjm-0002x1-Fj for submit@debbugs.gnu.org; Sat, 06 Sep 2014 04:52:50 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:55232) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQBjj-0002we-8I for 18381@debbugs.gnu.org; Sat, 06 Sep 2014 04:52:48 -0400 Original-Received: from [194.118.137.128] ([194.118.137.128]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LyVpm-1YUa8G39ew-015mzn; Sat, 06 Sep 2014 10:52:38 +0200 In-Reply-To: X-Provags-ID: V03:K0:ASFMllUO6C2UvViT3bppBfzFzWPfIenlDGv1uiRYDTHIdX+j4bh 363wHLFa+ZsvuIeGe89pg756UFAyQT5LXArxU/DeCmQ0DWDs6bW2j1H3hkIlDDitJa66xS4 VIVXm+7VZHNZjHwZBPNqd9V2pOwhARWyjvbltOU5IEcp49fiSOcVsQLC+vfSSdqZjRfinCZ SPkDvgF1ZfxyVqEsz7ChQ== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93088 Archived-At: > I disagree, the above seems cleaner to me. I don't like changing a > general-purpose function to fix a specific problem. Then I probably misinterpreted his patch. What is the "general-purpose function" you intend here? In general, if an application uses `display-buffer' or `pop-to-buffer' directly, the application should enclose the preferred way to display the buffer (or where not to display it) in the ACTION argument. `display-buffer-overriding-action' should be only used as a last resort: For example, when the targeted `display-buffer' call is nested in some macro, in which case, however, the binding will probably affect any other `display-buffer' call within that macro. Or, when the application deliberately wants to preclude any form of users' customization. > Why do you say "`display-buffer-overriding-action' is too drastic"? > It seems fine to me. Since coming up with that form, I've noticed that > isearch.el and lisp.el use something similar (or identical). > > I'm inclined to commit this solution... Saying "don't use the selected window" should never harm here (a user would never want to override that, I presume) so you should be on the safe side side with your solution. Still I wonder why you can't change `display-buffer' calls directly here. >> Is `calendar-in-read-only-buffer' presumably only executed in a state >> where the calendar window is shown and selected? > > I don't think so, no. But wouldn't then using `display-buffer-overriding-action' preclude the use of another window which is at that time shown and selected? martin