From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18381: 24.3.93; Diary can wrongly be displayed in Calendar's window Date: Fri, 05 Sep 2014 12:46:06 +0200 Message-ID: <5409946E.4040907@gmx.at> References: <87k35nqtdd.fsf@rosalinde.fritz.box> <54085AC5.5050304@gmx.at> <7lr3zrjm94.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1409914050 26603 80.91.229.3 (5 Sep 2014 10:47:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Sep 2014 10:47:30 +0000 (UTC) Cc: Stephen Berman , 18381@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 05 12:47:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XPr34-0000O9-Kz for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2014 12:47:22 +0200 Original-Received: from localhost ([::1]:56862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPr34-0000tH-BP for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2014 06:47:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPr2s-0000rv-U6 for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 06:47:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPr2l-0007xC-EI for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 06:47:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPr2l-0007x7-Ae for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 06:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XPr2k-0007xB-Nz for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 06:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Sep 2014 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18381-submit@debbugs.gnu.org id=B18381.140991398830509 (code B ref 18381); Fri, 05 Sep 2014 10:47:02 +0000 Original-Received: (at 18381) by debbugs.gnu.org; 5 Sep 2014 10:46:28 +0000 Original-Received: from localhost ([127.0.0.1]:59299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPr2A-0007w0-NI for submit@debbugs.gnu.org; Fri, 05 Sep 2014 06:46:27 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:60104) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPr26-0007vh-OS for 18381@debbugs.gnu.org; Fri, 05 Sep 2014 06:46:23 -0400 Original-Received: from [88.117.58.197] ([88.117.58.197]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M92ZJ-1XXJo50SFR-00CTP8; Fri, 05 Sep 2014 12:46:16 +0200 In-Reply-To: <7lr3zrjm94.fsf@fencepost.gnu.org> X-Provags-ID: V03:K0:L4HWvN8e2/0dA/wYygkFuwnHGe46Njmo9p5zvc3G5ZaPdbJyt1w 2E7tfWNhy27/2L40nmHRTLqBJNyJLvqmYrXuTK7DylgZzl8lZDJP840DJhmPyt2t3v+nmlh FbY5ngLwk9QXUXkTxtw8s+Czzb9k0ZLWM/ZI7t/HbN1VfZEaD8VM0ebfTfnD5kt8W86thba Bsx7ZO8Rw6P9qk99pZJHg== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93063 Archived-At: > The most conservative fix would seem to be to only change > calendar-basic-setup, where it calls diary-view-entries. Is that sufficient? I thought the problematic call is that of `display-buffer' in `calendar-in-read-only-buffer'. I must admit that I have a hard time debugging calendar code. > I guess what we really want to say is "don't display the diary in the > window that you just displayed the calendar in" (is that possible?), We can make that window softly dedicated to the calendar. But that's not very clean. > but > failing that, simply removing display-buffer-in-previous-window seems to > work. What's the cleanest way to do that? Binding > display-buffer-overriding-action or display-buffer-fallback-action > to an explicit list? display-buffer-fallback-action does not have the > friendliest format to make "remove element X" straightforward, > and is marked as a constant. If we can identify the specific `display-buffer' or `pop-to-buffer' calls in the calendar or diary code, we should pass it via the ACTION argument. That is, pass the value of `display-buffer-fallback-action' with `display-buffer-in-previous-window' removed. `display-buffer-overriding-action' is too drastic here and `display-buffer-fallback-action' should not be used indeed. Eventually, the code should be revised anyway. For example, when a window can be split, apparently the following sequence of actions is performed: (1) The calendar is displayed and its window is fit to the buffer. (2) The diary is displayed in a window split off from the calendar window annihilating the effort of `fit-window-to-buffer' and leaving me with some two lines of the calendar. martin