From: martin rudalics <rudalics@gmx.at>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 18357@debbugs.gnu.org
Subject: bug#18357: 24.3.93; Calendar not fully displayed
Date: Sun, 31 Aug 2014 13:28:57 +0200 [thread overview]
Message-ID: <540306F9.6040107@gmx.at> (raw)
In-Reply-To: <871trxrcso.fsf@rosalinde.fritz.box>
> If I follow you (but I'm not sure I do), I think you are mistaken here:
> when I step through the code, fit-window-to-buffer is called (in
> calendar-generate-window, as noted above) with *Calendar* buffer window
> already being the selected window. In any case, the estimate for the
> mode line height should be the same in my case as in yours, see below.
It seems you're right. If, with my recipe, I set a breakpoint at line
9880 in xdisp.c
y = y + WINDOW_MODE_LINE_HEIGHT (w);
then, for some reason I can't explain, the value of w->mode_line_height
is already set to a non-negative value although from my reading of the
code this should happen only if line 1428 of xdisp.c (in pos_visible_p)
was executed before, a thing which doesn't happen here. I must admit
that I don't understand the window mode line height caching mechanism.
> In my recipe, both active and inactive mode lines have the same height:
> face mode-line-inactive inherits the overline attribute from face
> mode-line.
>
> One interesting observation (which I do not understand), is that when I
> execute the recipe and step through calendar-generate-window with
> Edebug, after the call to fit-window-to-buffer, the height of the
> Calendar window is 9, and the Calendar is fully displayed. But when I
> execute the recipe alone, the height is 8 and the display is partial.
Probably edebug has the same effect as the `sit-for' in my scenario. It
redisplays the window and the new mode line height is used when fitting
the window. In any case the `sit-for' in my scenario makes sure that
w->mode_line_height is 20 at the breakpoint mentioned above as opposed
to 16 without the `sit-for'.
martin
next prev parent reply other threads:[~2014-08-31 11:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 18:24 bug#18357: 24.3.93; Calendar not fully displayed Stephen Berman
2014-08-29 19:07 ` Stephen Berman
2014-08-30 9:58 ` Eli Zaretskii
2014-08-30 11:32 ` Stephen Berman
2014-08-30 12:34 ` Eli Zaretskii
2014-08-30 14:07 ` Stephen Berman
2014-08-30 16:40 ` martin rudalics
2014-08-30 12:43 ` martin rudalics
2014-08-30 12:48 ` martin rudalics
2014-08-30 13:27 ` Eli Zaretskii
2014-08-30 13:51 ` martin rudalics
2014-08-30 14:09 ` Eli Zaretskii
2014-08-30 16:40 ` martin rudalics
2014-08-30 16:46 ` Eli Zaretskii
2014-08-30 17:15 ` martin rudalics
2014-08-30 17:54 ` Eli Zaretskii
2014-08-30 18:08 ` martin rudalics
2014-08-30 19:35 ` Stephen Berman
2014-08-31 11:28 ` martin rudalics [this message]
2014-09-01 9:18 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540306F9.6040107@gmx.at \
--to=rudalics@gmx.at \
--cc=18357@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.