From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#18366: 24.3.93; Definition of strnicmp needed for Cygwin-w32 build Date: Sat, 30 Aug 2014 15:49:25 -0400 Message-ID: <54022AC5.4080106@cornell.edu> References: <540214E3.4060208@cornell.edu> <83fvgdhjqd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1409428226 18158 80.91.229.3 (30 Aug 2014 19:50:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Aug 2014 19:50:26 +0000 (UTC) Cc: 18366-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 30 21:50:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNofD-0002TA-1K for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 21:50:19 +0200 Original-Received: from localhost ([::1]:47577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNofC-0003nv-Kf for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 15:50:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNof4-0003mv-E9 for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:50:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNoey-0000te-Fb for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:50:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNoey-0000sq-Bm for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNoex-0003Sp-D8 for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:50:03 -0400 Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Aug 2014 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18366 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 18366@debbugs.gnu.org, kbrown@cornell.edu, kbrown@cornell.edu Original-Received: via spool by 18366-done@debbugs.gnu.org id=D18366.140942817713269 (code D ref 18366); Sat, 30 Aug 2014 19:50:02 +0000 Original-Received: (at 18366-done) by debbugs.gnu.org; 30 Aug 2014 19:49:37 +0000 Original-Received: from localhost ([127.0.0.1]:54630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNoeX-0003Rv-7d for submit@debbugs.gnu.org; Sat, 30 Aug 2014 15:49:37 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:55903) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNoeU-0003Re-KW for 18366-done@debbugs.gnu.org; Sat, 30 Aug 2014 15:49:35 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s7UJnS7n024314; Sat, 30 Aug 2014 15:49:28 -0400 Original-Received: from [192.168.1.4] (cpe-67-249-176-226.twcny.res.rr.com [67.249.176.226]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s7UJnRu3010207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 30 Aug 2014 15:49:28 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: <83fvgdhjqd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92881 Archived-At: Version: 24.3.94 On 8/30/2014 3:15 PM, Eli Zaretskii wrote: >> Date: Sat, 30 Aug 2014 14:16:03 -0400 >> From: Ken Brown >> >> Cygwin's /usr/include/string.h, which comes from newlib, contains a >> definition of strnicmp; this is needed for the Cygwin-w32 build. That >> definition has recently been dropped from newlib > > Why did they do such a thing? https://sourceware.org/ml/newlib/2014/msg00309.html > The proper place for this kind of thing is src/conf_post.h, which will > also make sure you won't need to include cygw32.h in every file that > uses that function. (You'd probably need to condition this on > HAVE_NTGUI in addition to __CYGWIN__.) OK. > I'd also suggest to consider whether to make this a macro or an inline > function, and perhaps also condition that on the Cygwin or newlib's > version rather than on #ifndef (what if newlib will add a function by > that name?). But this is up to you. It was added to newlib in 1977 (as a macro), and the discussion in the URL above explains why it has long been obsolete from Cygwin's point of view. So I think I'll leave it as a macro. >> Is it OK for the release branch? > > Yes, with the above taken care of. Thanks. Done, as revision 117467. Ken