From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18366-done@debbugs.gnu.org
Subject: bug#18366: 24.3.93; Definition of strnicmp needed for Cygwin-w32 build
Date: Sat, 30 Aug 2014 15:49:25 -0400 [thread overview]
Message-ID: <54022AC5.4080106@cornell.edu> (raw)
In-Reply-To: <83fvgdhjqd.fsf@gnu.org>
Version: 24.3.94
On 8/30/2014 3:15 PM, Eli Zaretskii wrote:
>> Date: Sat, 30 Aug 2014 14:16:03 -0400
>> From: Ken Brown <kbrown@cornell.edu>
>>
>> Cygwin's /usr/include/string.h, which comes from newlib, contains a
>> definition of strnicmp; this is needed for the Cygwin-w32 build. That
>> definition has recently been dropped from newlib
>
> Why did they do such a thing?
https://sourceware.org/ml/newlib/2014/msg00309.html
> The proper place for this kind of thing is src/conf_post.h, which will
> also make sure you won't need to include cygw32.h in every file that
> uses that function. (You'd probably need to condition this on
> HAVE_NTGUI in addition to __CYGWIN__.)
OK.
> I'd also suggest to consider whether to make this a macro or an inline
> function, and perhaps also condition that on the Cygwin or newlib's
> version rather than on #ifndef (what if newlib will add a function by
> that name?). But this is up to you.
It was added to newlib in 1977 (as a macro), and the discussion in the
URL above explains why it has long been obsolete from Cygwin's point of
view. So I think I'll leave it as a macro.
>> Is it OK for the release branch?
>
> Yes, with the above taken care of.
Thanks. Done, as revision 117467.
Ken
prev parent reply other threads:[~2014-08-30 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 18:16 bug#18366: 24.3.93; Definition of strnicmp needed for Cygwin-w32 build Ken Brown
2014-08-30 19:15 ` Eli Zaretskii
2014-08-30 19:49 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54022AC5.4080106@cornell.edu \
--to=kbrown@cornell.edu \
--cc=18366-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.