From: Ken Brown <kbrown@cornell.edu>
To: 18366@debbugs.gnu.org
Subject: bug#18366: 24.3.93; Definition of strnicmp needed for Cygwin-w32 build
Date: Sat, 30 Aug 2014 14:16:03 -0400 [thread overview]
Message-ID: <540214E3.4060208@cornell.edu> (raw)
Cygwin's /usr/include/string.h, which comes from newlib, contains a
definition of strnicmp; this is needed for the Cygwin-w32 build. That
definition has recently been dropped from newlib, and so it will be gone
in the next Cygwin release. The following patch fixes the problem. Is
it OK for the release branch?
=== modified file 'src/cygw32.h'
--- src/cygw32.h 2014-01-01 07:43:34 +0000
+++ src/cygw32.h 2014-08-30 17:51:36 +0000
@@ -33,6 +33,11 @@
#include "lisp.h"
#include "coding.h"
+/* The following was in /usr/include/string.h prior to Cygwin 1.7.33. */
+#ifndef strnicmp
+#define strnicmp strncasecmp
+#endif
+
extern void syms_of_cygw32 (void);
extern char * w32_strerror (int error_no);
=== modified file 'src/w32font.c'
--- src/w32font.c 2014-01-19 15:42:48 +0000
+++ src/w32font.c 2014-08-30 17:47:35 +0000
@@ -35,6 +35,8 @@
#include "w32font.h"
#ifdef WINDOWSNT
#include "w32.h"
+#else /* CYGWIN */
+#include "cygw32.h"
#endif
/* Cleartype available on Windows XP, cleartype_natural from XP SP1.
=== modified file 'src/w32reg.c'
--- src/w32reg.c 2014-01-01 07:43:34 +0000
+++ src/w32reg.c 2014-08-30 17:47:35 +0000
@@ -26,6 +26,10 @@
#include <stdio.h>
+#ifdef CYGWIN
+#include "cygw32.h"
+#endif
+
#define REG_ROOT "SOFTWARE\\GNU\\Emacs"
/* Default system colors from the Display Control Panel settings. */
next reply other threads:[~2014-08-30 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 18:16 Ken Brown [this message]
2014-08-30 19:15 ` bug#18366: 24.3.93; Definition of strnicmp needed for Cygwin-w32 build Eli Zaretskii
2014-08-30 19:49 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540214E3.4060208@cornell.edu \
--to=kbrown@cornell.edu \
--cc=18366@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.