From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#18347: 24.3.93; Incomplete splash screen display on Cygwin-w32 build Date: Fri, 29 Aug 2014 11:08:21 -0400 Message-ID: <54009765.8040509@cornell.edu> References: <53FFA44A.3040602@cornell.edu> <83sikfizia.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1409324971 15509 80.91.229.3 (29 Aug 2014 15:09:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Aug 2014 15:09:31 +0000 (UTC) Cc: 18347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 29 17:09:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNNni-0001bU-72 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Aug 2014 17:09:18 +0200 Original-Received: from localhost ([::1]:42502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNNnh-00079g-Ho for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Aug 2014 11:09:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNNnZ-00078i-G8 for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:09:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNNnT-0000kT-IN for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:09:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNNnT-0000kP-Eq for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNNnS-0004pz-UJ for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:09:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Aug 2014 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18347 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18347-submit@debbugs.gnu.org id=B18347.140932492018561 (code B ref 18347); Fri, 29 Aug 2014 15:09:02 +0000 Original-Received: (at 18347) by debbugs.gnu.org; 29 Aug 2014 15:08:40 +0000 Original-Received: from localhost ([127.0.0.1]:53647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNNn5-0004pI-JB for submit@debbugs.gnu.org; Fri, 29 Aug 2014 11:08:39 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:45761) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNNn3-0004ov-6G for 18347@debbugs.gnu.org; Fri, 29 Aug 2014 11:08:38 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s7TF8PlL007321; Fri, 29 Aug 2014 11:08:26 -0400 Original-Received: from [128.84.234.164] (dijon.math.cornell.edu [128.84.234.164]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s7TF8Pxa014838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 29 Aug 2014 11:08:25 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: <83sikfizia.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92805 Archived-At: On 8/29/2014 2:25 AM, Eli Zaretskii wrote: >> Date: Thu, 28 Aug 2014 17:51:06 -0400 >> From: Ken Brown >> >> --- lisp/startup.el 2014-07-08 09:17:09 +0000 >> +++ lisp/startup.el 2014-08-28 20:07:20 +0000 >> @@ -1812,7 +1812,7 @@ >> (let (chosen-frame) >> ;; MS-Windows needs this to have a chance to make the initial >> ;; frame visible. >> - (if (eq system-type 'windows-nt) >> + (if (eq window-system 'w32) >> (sit-for 0 t)) >> (dolist (frame (append (frame-list) (list (selected-frame)))) >> (if (and (frame-visible-p frame) > > It is fundamentally wrong to use window-system the variable in such > circumstances (or almost any other). Please use the function instead. OK. But could you explain why? TIA. >> Is this still OK for the native Windows build? If so, is it OK to >> install it in the release branch? > > Yes and yes. Although I'd urge you to try to figure out why this is > needed in the cygwin-w32 build (the native-build problem which led to > this code manifested itself in a rather different way, see bug#16014). Actually, the visual symptom I'm describing (failure of the logo to appear) is identical to what Juanma reported in that bug. Your message in that bug discussion says, "It's again that timing thing with making the initial frame visible." The "again" suggests that there is an earlier bug report or discussion about that. Can you give me a reference or just explain what you meant by that? Ken