bug#75023: 31.0.50; Warning: Unused lexical variable ‘max-tokens’ -- while used in function

bug#75023: 31.0.50; Warning: Unused lexical variable ‘max-tokens’ -- while used in function

[Jean Louis]

(defun rcd-llm-db (prompt &optional memory rcd-llm-model temperature max-tokens top-p stream)
  "Send PROMPT to API as decided by the database.

Optional MEMORY, RCD-LLM-MODEL, TEMPERATURE, MAX-TOKENS, TOP-P, and STREAM can be used."
  (let ((rcd-llm-model-id (rcd-db-users-defaults "llmmodels")))
    (cond ((not rcd-llm-model-id) (rcd-warning-message "Did not find default user's LLM model. Do `M-x rcd-my-defaults' to set it."))
	  (t (let* ((rcd-llm-model (rcd-db-get-entry "llmmodels" "llmmodels_name" rcd-llm-model-id rcd-db))
		    (temperature (or temperature (rcd-db-get-entry "llmmodels" "llmmodels_temperature" rcd-llm-model-id rcd-db)))
		    (max-tokens (or max-tokens (rcd-db-get-entry "llmmodels" "llmmodels_maxtokens" rcd-llm-model-id rcd-db)))
		    (top-p (or top-p (rcd-db-get-entry "llmmodels" "llmmodels_topp" rcd-llm-model-id rcd-db)))
		    (llm-endpoint-id (rcd-db-get-entry "llmmodels" "llmmodels_llmendpoints" rcd-llm-model-id rcd-db))
		    (llm-endpoint (rcd-db-get-entry "llmendpoints" "llmendpoints_name" llm-endpoint-id rcd-db))
		    (llm-provider-id (rcd-db-get-entry "llmendpoints" "llmendpoints_llmproviders" llm-endpoint-id rcd-db))
		    (api-key (rcd-db-get-entry "llmproviders" "llmproviders_apikey" llm-provider-id rcd-db))
		    (authorization (concat "Bearer " api-key))
		    (stream (if stream t :json-false))
		    (url-request-method "POST")
		    (url-request-extra-headers
		     `(("Content-Type" . "application/json")
		       ("Authorization" . ,authorization)))
		    (url-request-data
		     (encode-coding-string
		      (setq rcd-llm-last-json
			    (json-encode
			     `((model . ,rcd-llm-model)
			       (messages . [((role . "user") (content . ,prompt))])
			       (temperature . ,temperature)
			       (max_tokens . ,max-tokens)
			       (top_p . ,top-p)
			       (stream . ,stream))))
		      'utf-8))
		    (buffer (url-retrieve-synchronously llm-endpoint)))
	       (rcd-llm-response buffer))))))


in that above function I am using ,max-tokens, but with interpolation.

Though, byte compiler gives warning:

Unused lexical variable ‘max-tokens’ -- while used in function



In GNU Emacs 31.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2024-12-05 built on lco2
Repository revision: 25b4bf7fcd75564f23b2e60e29e8ff7354186371
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --with-mailutils --with-native-compilation=yes
 --with-tree-sitter --with-imagemagick'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG LCMS2 LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
native-compile emacs)

Memory information:
((conses 16 49957 10576) (symbols 48 5434 0) (strings 32 14149 1196)
 (string-bytes 1 395119) (vectors 16 9194)
 (vector-slots 8 130226 9961) (floats 8 22 2) (intervals 56 244 8)
 (buffers 992 11))

-- 
Jean Louis

bug#75023: 31.0.50; Warning: Unused lexical variable ‘max-tokens’ -- while used in function

[Stefan Kangas]

tags 75023 + moreinfo
thanks

Jean Louis <bugs@gnu.support> writes:

> (defun rcd-llm-db (prompt &optional memory rcd-llm-model temperature max-tokens top-p stream)
>   "Send PROMPT to API as decided by the database.
>
> Optional MEMORY, RCD-LLM-MODEL, TEMPERATURE, MAX-TOKENS, TOP-P, and STREAM can be used."
>   (let ((rcd-llm-model-id (rcd-db-users-defaults "llmmodels")))
>     (cond ((not rcd-llm-model-id) (rcd-warning-message "Did not find default user's LLM model. Do `M-x rcd-my-defaults' to set it."))
> 	  (t (let* ((rcd-llm-model (rcd-db-get-entry "llmmodels" "llmmodels_name" rcd-llm-model-id rcd-db))
> 		    (temperature (or temperature (rcd-db-get-entry "llmmodels" "llmmodels_temperature" rcd-llm-model-id rcd-db)))
> 		    (max-tokens (or max-tokens (rcd-db-get-entry "llmmodels" "llmmodels_maxtokens" rcd-llm-model-id rcd-db)))
> 		    (top-p (or top-p (rcd-db-get-entry "llmmodels" "llmmodels_topp" rcd-llm-model-id rcd-db)))
> 		    (llm-endpoint-id (rcd-db-get-entry "llmmodels" "llmmodels_llmendpoints" rcd-llm-model-id rcd-db))
> 		    (llm-endpoint (rcd-db-get-entry "llmendpoints" "llmendpoints_name" llm-endpoint-id rcd-db))
> 		    (llm-provider-id (rcd-db-get-entry "llmendpoints" "llmendpoints_llmproviders" llm-endpoint-id rcd-db))
> 		    (api-key (rcd-db-get-entry "llmproviders" "llmproviders_apikey" llm-provider-id rcd-db))
> 		    (authorization (concat "Bearer " api-key))
> 		    (stream (if stream t :json-false))
> 		    (url-request-method "POST")
> 		    (url-request-extra-headers
> 		     `(("Content-Type" . "application/json")
> 		       ("Authorization" . ,authorization)))
> 		    (url-request-data
> 		     (encode-coding-string
> 		      (setq rcd-llm-last-json
> 			    (json-encode
> 			     `((model . ,rcd-llm-model)
> 			       (messages . [((role . "user") (content . ,prompt))])
> 			       (temperature . ,temperature)
> 			       (max_tokens . ,max-tokens)
> 			       (top_p . ,top-p)
> 			       (stream . ,stream))))
> 		      'utf-8))
> 		    (buffer (url-retrieve-synchronously llm-endpoint)))
> 	       (rcd-llm-response buffer))))))
>
>
> in that above function I am using ,max-tokens, but with interpolation.
>
> Though, byte compiler gives warning:
>
> Unused lexical variable ‘max-tokens’ -- while used in function

Could you please send a smaller example that reproduces the bug?

bug#75023: 31.0.50; Warning: Unused lexical variable ‘max-tokens’ -- while used in function

[Charalampos Mitrodimas]

Hi Jean,

On 22/12/24 2:10 PM, Jean Louis wrote:
> (defun rcd-llm-db (prompt &optional memory rcd-llm-model temperature max-tokens top-p stream)
>    "Send PROMPT to API as decided by the database.
>
> Optional MEMORY, RCD-LLM-MODEL, TEMPERATURE, MAX-TOKENS, TOP-P, and STREAM can be used."
>    (let ((rcd-llm-model-id (rcd-db-users-defaults "llmmodels")))
>      (cond ((not rcd-llm-model-id) (rcd-warning-message "Did not find default user's LLM model. Do `M-x rcd-my-defaults' to set it."))
> 	  (t (let* ((rcd-llm-model (rcd-db-get-entry "llmmodels" "llmmodels_name" rcd-llm-model-id rcd-db))
> 		    (temperature (or temperature (rcd-db-get-entry "llmmodels" "llmmodels_temperature" rcd-llm-model-id rcd-db)))
> 		    (max-tokens (or max-tokens (rcd-db-get-entry "llmmodels" "llmmodels_maxtokens" rcd-llm-model-id rcd-db)))
> 		    (top-p (or top-p (rcd-db-get-entry "llmmodels" "llmmodels_topp" rcd-llm-model-id rcd-db)))
> 		    (llm-endpoint-id (rcd-db-get-entry "llmmodels" "llmmodels_llmendpoints" rcd-llm-model-id rcd-db))
> 		    (llm-endpoint (rcd-db-get-entry "llmendpoints" "llmendpoints_name" llm-endpoint-id rcd-db))
> 		    (llm-provider-id (rcd-db-get-entry "llmendpoints" "llmendpoints_llmproviders" llm-endpoint-id rcd-db))
> 		    (api-key (rcd-db-get-entry "llmproviders" "llmproviders_apikey" llm-provider-id rcd-db))
> 		    (authorization (concat "Bearer " api-key))
> 		    (stream (if stream t :json-false))
> 		    (url-request-method "POST")
> 		    (url-request-extra-headers
> 		     `(("Content-Type" . "application/json")
> 		       ("Authorization" . ,authorization)))
> 		    (url-request-data
> 		     (encode-coding-string
> 		      (setq rcd-llm-last-json
> 			    (json-encode
> 			     `((model . ,rcd-llm-model)
> 			       (messages . [((role . "user") (content . ,prompt))])
> 			       (temperature . ,temperature)
> 			       (max_tokens . ,max-tokens)
> 			       (top_p . ,top-p)
> 			       (stream . ,stream))))
> 		      'utf-8))
> 		    (buffer (url-retrieve-synchronously llm-endpoint)))
> 	       (rcd-llm-response buffer))))))
>
>
> in that above function I am using ,max-tokens, but with interpolation.
>
> Though, byte compiler gives warning:
>
> Unused lexical variable ‘max-tokens’ -- while used in function

I tried to reproduce this but got these instead,

In rcd-llm-db:
test.el:3:2: Warning: docstring wider than 80 characters
test.el:9:100: Warning: reference to free variable ‘rcd-db’
test.el:25:29: Warning: assignment to free variable ‘rcd-llm-last-json’

In end of data:
test.el:35:17: Warning: the function ‘rcd-llm-response’ is not known to be
     defined.
test.el:9:37: Warning: the function ‘rcd-db-get-entry’ is not known to be
     defined.
test.el:8:36: Warning: the function ‘rcd-warning-message’ is not known to be
     defined.
test.el:7:28: Warning: the function ‘rcd-db-users-defaults’ is not known 
to be
     defined.


I agree that a smaller example to reproduce this would be better.

--
C. Mitrodimas