From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Date: Sat, 4 Dec 2021 12:56:09 -0800 Message-ID: <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> <86h7bouq5f.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52237@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 04 21:57:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtc5m-0006MO-PU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 21:57:10 +0100 Original-Received: from localhost ([::1]:42352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtc5k-0001Kl-M7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 15:57:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtc5d-0001KL-Tw for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 15:57:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtc5d-0002ta-MK for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 15:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtc5d-0003mv-Ln for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 15:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163865137914511 (code B ref 52237); Sat, 04 Dec 2021 20:57:01 +0000 Original-Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 20:56:19 +0000 Original-Received: from localhost ([127.0.0.1]:55254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtc4x-0003lz-K9 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 15:56:19 -0500 Original-Received: from mail-pf1-f180.google.com ([209.85.210.180]:44576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtc4v-0003li-8j for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 15:56:17 -0500 Original-Received: by mail-pf1-f180.google.com with SMTP id b68so6324446pfg.11 for <52237@debbugs.gnu.org>; Sat, 04 Dec 2021 12:56:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Zg/LYzshwMYtYuvm40tczzoI7xTERJ0DcpCzxs6x8jM=; b=Afu9p4coEPzIid1A8RdTQa3uDUtytzPhUowTvHZKuIMUR4uIXee2H+/VhXpBR50tEY whewIV1J9VKdI1RT+FpUmby1NuRWVo5Ryi9l2tkEWAjSgix2L+LrCEkd6xgfvCgWD4ea X6PXxrMYDEVUq3cjvIHamcfqcPxW+BDevSJHGN0S7BOa2SAxChE8yj++zsL9LHb2Blmi F9MeJNP5AqVL2Xu9QkAQw00otO8DLa5O45cz/u+av0yW7QVpRljDPhubWtvmE9EKovoq wsT5Ny6ZhSujEFL9i2zy9aLQYTrz0KuDYuXbv548kNkTFexNiL5R2aBdVM5GS1SNzpEv J+fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Zg/LYzshwMYtYuvm40tczzoI7xTERJ0DcpCzxs6x8jM=; b=OwIOlIBxzH+0kljq54ALjnlFts9s69oq6dIHhAOiExBHAF9cqIloGXOfGIvk6Ikskw UbPL4R+wvQ5zbYn3F6AVrIx+KEmlOPVxk5qN5/aPShRc+sSwt7WHIlZ/O8T7+mnElB3t 4K49HUqvNNsRd8PpTsrR21d6G0OkVC7QHoLnSYVu0oDBlLuA27TzD+YnNOSFy13Y3hL2 VRFom62GrbDR+5oz0Qi4VtsdL3QjC+z5shUscG/D1dEHKguoXLSfFEAHApafItChgAUt UyTeisWYhSQ4x+Rebb/VoPPI8pdjt54weS+55xjtdh1B+qIDc2v4zRZDpf/oHbXRYFuz Bj/Q== X-Gm-Message-State: AOAM531GxHPxnHgzDfmRDpetxLnzofNBx3Kn3aealvzYnhfRqFbHk6JO m6FTPQ8ABhc+QtGkiAwFM6+UfyLTUXI= X-Google-Smtp-Source: ABdhPJy2L+jBYwwkJugTI8XeDlB8j+hUdPTuBRIG8OyppNl8rf6eSnTW86dlzAoM+/9OmwqwBRYWpQ== X-Received: by 2002:a63:8948:: with SMTP id v69mr10938352pgd.250.1638651371245; Sat, 04 Dec 2021 12:56:11 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g14sm5621920pgo.88.2021.12.04.12.56.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Dec 2021 12:56:10 -0800 (PST) In-Reply-To: <86h7bouq5f.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221509 Archived-At: On 12/4/2021 11:50 AM, Juri Linkov wrote: >> I found another odd case, but I'm not 100% sure the best way to fix it: >> >> emacs -Q --eval '(context-menu-mode)' >> C-h o identity RET >> ;; Right-click somewhere in the Help buffer >> >> There's a doubled separator after "Next Topic". [snip] > I see no simpler way, so perhaps we need to add `context-menu-top-separator'. Sounds good. I'll work on a patch for this and file a new bug for it once it's ready. >> [1] As an aside, is there a standard naming convention to use here? Should >> "separator" go at the beginning of the name or the end? > > `context-menu-middle-separator' is a function, so it requires the > `context-menu-' prefix. It adds the menu item [middle-separator]. > Since "middle" is an adjective, the word order can't be "separator-middle". > But "buffers-separator" doesn't look nicer than `separator-buffers'. I think `FOO-separator' is the best choice here for the separators themselves. `FOO' acts as a noun adjunct[1], modifying the underlying object: a separator. For functions that just make a separator, they'd be named `MODULE-[FOO-]-separator', with `FOO-' being optional if it would be redundant with the module name. So then `context-menu-middle-separator' is the right function name, and it adds a separator named `middle-separator'. `buffers-separator' is a bit of an odd phrasing since, as the Wikipedia article mentions, "Noun adjuncts were traditionally mostly singular". However, I think it's still a bit easier to read that correctly as "the separator used to mark the buffers", whereas `separator-buffers' reads more like "buffers used to separate things" to me. Since this should just be a trivial renaming, hopefully we can merge that into Emacs 28 so we're not locked into the current names. [1] https://en.wikipedia.org/wiki/Noun_adjunct