From: Jim Porter <jporterbugs@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 52237@debbugs.gnu.org
Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode
Date: Sat, 4 Dec 2021 12:56:09 -0800 [thread overview]
Message-ID: <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> (raw)
In-Reply-To: <86h7bouq5f.fsf@mail.linkov.net>
On 12/4/2021 11:50 AM, Juri Linkov wrote:
>> I found another odd case, but I'm not 100% sure the best way to fix it:
>>
>> emacs -Q --eval '(context-menu-mode)'
>> C-h o identity RET
>> ;; Right-click somewhere in the Help buffer
>>
>> There's a doubled separator after "Next Topic".
[snip]
> I see no simpler way, so perhaps we need to add `context-menu-top-separator'.
Sounds good. I'll work on a patch for this and file a new bug for it
once it's ready.
>> [1] As an aside, is there a standard naming convention to use here? Should
>> "separator" go at the beginning of the name or the end?
>
> `context-menu-middle-separator' is a function, so it requires the
> `context-menu-' prefix. It adds the menu item [middle-separator].
> Since "middle" is an adjective, the word order can't be "separator-middle".
> But "buffers-separator" doesn't look nicer than `separator-buffers'.
I think `FOO-separator' is the best choice here for the separators
themselves. `FOO' acts as a noun adjunct[1], modifying the underlying
object: a separator. For functions that just make a separator, they'd be
named `MODULE-[FOO-]-separator', with `FOO-' being optional if it would
be redundant with the module name. So then
`context-menu-middle-separator' is the right function name, and it adds
a separator named `middle-separator'.
`buffers-separator' is a bit of an odd phrasing since, as the Wikipedia
article mentions, "Noun adjuncts were traditionally mostly singular".
However, I think it's still a bit easier to read that correctly as "the
separator used to mark the buffers", whereas `separator-buffers' reads
more like "buffers used to separate things" to me.
Since this should just be a trivial renaming, hopefully we can merge
that into Emacs 28 so we're not locked into the current names.
[1] https://en.wikipedia.org/wiki/Noun_adjunct
next prev parent reply other threads:[~2021-12-04 20:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 6:06 bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Jim Porter
2021-12-02 8:24 ` Lars Ingebrigtsen
2021-12-02 17:44 ` Juri Linkov
2021-12-03 4:46 ` bug#52237: 29.0.50; [PATCH 2] " Jim Porter
2021-12-03 16:10 ` Lars Ingebrigtsen
2021-12-05 9:32 ` Juri Linkov
2021-12-05 20:20 ` Lars Ingebrigtsen
2021-12-03 16:08 ` bug#52237: 29.0.50; [PATCH] " Lars Ingebrigtsen
2021-12-04 6:44 ` Jim Porter
2021-12-04 8:26 ` Eli Zaretskii
2021-12-02 17:31 ` bug#52237: [External] : " Drew Adams
2021-12-02 18:09 ` Jim Porter
2021-12-02 18:25 ` bug#52237: [External] : " Drew Adams
2021-12-02 18:47 ` Jim Porter
2021-12-04 19:50 ` Juri Linkov
2021-12-04 20:56 ` Jim Porter [this message]
2021-12-04 22:09 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com \
--to=jporterbugs@gmail.com \
--cc=52237@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.