all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: William Xu <william.xwl@gmail.com>, 15560@debbugs.gnu.org
Subject: bug#15560: 24.3.50; [patch] * imenu.el (imenu--generic-function): Don't generate index for comments area.
Date: Tue, 8 Oct 2013 14:58:04 -0700 (PDT)	[thread overview]
Message-ID: <53e07508-fd4c-42e0-8729-68d6db182a70@default> (raw)
In-Reply-To: <CACzMC-BqYFN1Cseg+d_Njg=J=C3wMj3HOdtwKmi+cQ48XpTQdg@mail.gmail.com>

> It is annoying when imenu generates index also for functions found
> in comments area.

Yes!  And no.  It depends what you want at the particular time.
Sometimes you have multiple versions of a definition, with all
but one commented out, and you *want* Imenu to present you with
all of them, for easy navigation among them. 

> imenu will generate two filesys_init, which makes imenu useless.

No, not useless - see above.  Sometimes annoying, sometimes useful.

> This patch skips comment area completely.  In this case, it will
> generate only one filesys_init.

It's not great to impose this behavior on users: they lose a feature
that way.  Better to let users choose, and let them toggle the behavior.

(I do that in Imenu+, for instance: the Imenu menu always contains
these additional menu items, which affect Imenu behavior: Toggle
Case-Sensitive Name-Sort, Toggle Ignoring Commented Defs, Toggle
Sorting.)





  reply	other threads:[~2013-10-08 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08  8:17 bug#15560: 24.3.50; [patch] * imenu.el (imenu--generic-function): Don't generate index for comments area William Xu
2013-10-08 21:58 ` Drew Adams [this message]
2013-10-09  9:21   ` William Xu
2013-10-09 12:23     ` Stefan Monnier
2013-10-09 14:31       ` Drew Adams
2013-10-09 14:31     ` Drew Adams
2013-11-24 21:28     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53e07508-fd4c-42e0-8729-68d6db182a70@default \
    --to=drew.adams@oracle.com \
    --cc=15560@debbugs.gnu.org \
    --cc=william.xwl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.