From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Date: Sun, 29 Dec 2024 05:22:48 +0200 Message-ID: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1231"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Felician Nemeth , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Troy Brown , 74914@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 29 04:24:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRjuk-000095-Ju for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Dec 2024 04:24:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRjuO-0007CL-M3; Sat, 28 Dec 2024 22:24:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRjuN-0007Bo-1F for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 22:24:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRjuM-00080Z-OZ for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 22:24:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=rzbJlE7E9S8m1dy8E0uznIG+eo3zvWlVKW0xW0F5yaM=; b=rTy835wXKi6Lxzs6mS2fvCFPvP2DdYw16XRA7v6566gjRbbCtmOXjUkq1/6xweW9pjGoG8GbBMgezmXEXX1GQlbE1UzQMEOeQq/ImUai93o/4PUjp95kikgcX9Z2VGh26OWu9PCLQIzFj+e9UdSOxH2FuWbbM/7+5B1KheG6Lnu2cYKfp6b/mSdPtimZ8Hx0DzdJRxSVR5xzm386XWBwVogDtbAtz/3bDE7ruwEuhwmtZngfwskt9kKnFbZkn5dfo1pHxpPeFX/hRnUZLMRK7y4ze0YKqlHiVdJJpFNkxJ77m39RbVCD8+hIXBTPqMXhtdTy+cRiv5NtWfpn14MIZQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRjuL-0003kb-Ld for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 22:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2024 03:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs Original-Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.173544258214330 (code B ref 74914); Sun, 29 Dec 2024 03:24:01 +0000 Original-Received: (at 74914) by debbugs.gnu.org; 29 Dec 2024 03:23:02 +0000 Original-Received: from localhost ([127.0.0.1]:53301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRjtO-0003ie-1C for submit@debbugs.gnu.org; Sat, 28 Dec 2024 22:23:02 -0500 Original-Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]:41043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRjtL-0003iM-SS for 74914@debbugs.gnu.org; Sat, 28 Dec 2024 22:23:00 -0500 Original-Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 73EFD25400E5; Sat, 28 Dec 2024 22:22:53 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 28 Dec 2024 22:22:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1735442573; x=1735528973; bh=rzbJlE7E9S8m1dy8E0uznIG+eo3zvWlVKW0xW0F5yaM=; b= kg9Fe4Z5Gim6QNTG057W2gCAjVKJjOZXDvlQ10qJ2KJvVblWGhQTuNFkxFnFMX5I 9hShOUbuP3MNSAnXkmA+tqs93m0IvER+4dq0jWAWXri9SbPzjVVC5ElG4XR1Du5z GolRTnXqCL2LDsYNFTVf40IfeDWiR/d49NMnGIFvNzKv8utGYxn34lEHnHfE0+BB g3fC+gKvstMMpm9A9N8aIYQuQxxDStjprnLN96AnHv1I1CnxmPgnOXuB4P/DOdqs yZ18tOmo6kDc0XkFVEaiJXM3pKGLzQ7x5K/ZhuxAhaqBMAOD/3aP9XdsBfMMbydK 5EcMnRMKsMfUGdrVDAhS3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735442573; x= 1735528973; bh=rzbJlE7E9S8m1dy8E0uznIG+eo3zvWlVKW0xW0F5yaM=; b=H LjkF3J5/vlWFbOgivCHAuNr4MS0XIe58nYw0eYErm5OGfTJYZatMOp5pzfUSlvHq DWDPiqv29tNaYgxPwxTMPWQa9qVoci4t1dnQdE32z0HbUQDstCUmpCu1/XyGWRIZ u/39eZZjZC+TC/bh66+/XidwJYITKPawSWDnanTdMvgBQS7QgH666BNEIs6NfmBh mtPsFutqEcSzH6zVKlnU6mGfID62WgWeVH3FI+kRk7kxCQk0djB62oOFIEDr5f38 isk2w/ylcnVg+fnaKmXVgxPMXQvtXQABnwUEvivbcUeJzPmtY4NuA1V1dxZID5Fk FdOzUbbNcUa1vvOkESHjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvfedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsrhhofihnthhssehtrhhohi gsrhhofihnrdguvghvpdhrtghpthhtohepjeegledugeesuggvsggsuhhgshdrghhnuhdr ohhrghdprhgtphhtthhopehfvghlihgtihgrnhdrnhgvmhgvthhhsehgmhgrihhlrdgtoh hmpdhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 Dec 2024 22:22:51 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297927 Archived-At: Hi! On 16/12/2024 17:19, Troy Brown wrote: > I believe the reason for Eglot's behavior is due to the way > "active-param" is specified in the cl-loop within `eglot--sig-info`. > ```text > with active-param = (or sig-active activeParameter) > ``` > The value of activeParameter in SignatureInformation (activeParameter) > should be given higher priority (i.e., listed first) over the > activeParameter specified in SignatureHelp (sig-active). So, does this fix the problem for you? diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 816a1e67eca..51c19d5681a 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3416,7 +3416,7 @@ eglot--sig-info 'font-lock-function-name-face)))) ;; Now to the parameters (cl-loop - with active-param = (or sig-active activeParameter) + with active-param = (or activeParameter sig-active) for i from 0 for parameter across parameters do (eglot--dbind ((ParameterInformation) ((:label parlabel))