From: Paul Eggert <eggert@cs.ucla.edu>
To: Michael Albinus <michael.albinus@gmx.de>, Eli Zaretskii <eliz@gnu.org>
Cc: dmantipov@yandex.ru, 18051@debbugs.gnu.org
Subject: bug#18051: [Emacs-diffs] trunk r117726: Add string collation.
Date: Wed, 27 Aug 2014 12:08:52 -0700 [thread overview]
Message-ID: <53FE2CC4.9060308@cs.ucla.edu> (raw)
In-Reply-To: <53FE2ACD.10502@cs.ucla.edu>
A couple more things.
First, the current algorithm looks only at LC_COLLATE, but the usual
approach is to default LC_COLLATE to LANG if LC_COLLATE isn't set, and
to have LC_ALL override LC_COLLATE. Shouldn't Emacs take a similar
approach, for compatibility?
More generally, it strikes me that string-collate-lessp will be quite
slow due to the overhead of looking up the locale environment string and
creating and destroying a locale for each string comparison. Instead,
shouldn't Emacs should have a locale object that the Emacs Lisp
programmer can create, an object that encapsulates the low level
locale_t object, and which can be passed as an optional argument to
string-collate-lessp? That way, string-collate-p would never have to
inspect the environment itself, or to create or destroy a locale.
next prev parent reply other threads:[~2014-08-27 19:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 4:05 [Emacs-diffs] trunk r117726: Add string collation Dmitry Antipov
2014-08-25 5:48 ` bug#18051: " Paul Eggert
2014-08-25 6:19 ` Dmitry Antipov
2014-08-25 6:41 ` Michael Albinus
2014-08-25 15:03 ` Eli Zaretskii
2014-08-25 16:01 ` Eli Zaretskii
2014-08-27 11:24 ` Michael Albinus
2014-08-27 15:40 ` Eli Zaretskii
2014-08-27 18:12 ` Michael Albinus
2014-08-27 18:26 ` Eli Zaretskii
2014-08-27 19:00 ` Paul Eggert
2014-08-27 19:08 ` Paul Eggert [this message]
2014-08-27 19:54 ` Eli Zaretskii
2014-08-27 21:27 ` Paul Eggert
2014-08-27 21:37 ` Michael Albinus
2014-08-28 2:39 ` Eli Zaretskii
2014-08-29 8:59 ` martin rudalics
2014-08-29 9:59 ` Michael Albinus
2014-08-29 17:21 ` martin rudalics
2014-08-29 17:56 ` Michael Albinus
2014-08-29 10:06 ` Eli Zaretskii
2014-08-29 18:01 ` Michael Albinus
2014-08-29 19:31 ` Eli Zaretskii
2014-08-29 21:01 ` Michael Albinus
2014-09-01 15:20 ` Eli Zaretskii
2014-09-01 20:46 ` Michael Heerdegen
2014-10-17 20:26 ` Michael Heerdegen
2014-10-18 5:38 ` Eli Zaretskii
2014-10-18 14:27 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE2CC4.9060308@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=18051@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.