all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18285@debbugs.gnu.org
Subject: bug#18285: 24.3.92; A combination of `display' on text and `invisible' and	`before/after-string' leads to the before/after string being	displayed twice
Date: Sun, 24 Aug 2014 05:28:42 +0400	[thread overview]
Message-ID: <53F93FCA.2040607@yandex.ru> (raw)
In-Reply-To: <83iolkmeg4.fsf@gnu.org>

On 08/23/2014 12:55 AM, Eli Zaretskii wrote:

> Look at the code inside load_overlay_strings that handles this, to
> understand what I'm saying.

Do you mean the situation when the `invisible' overlay starts before the 
`display' starts? And then we skip to the end because of `invisible', 
but that position is covered by `display', so if we ignore the 
`invisible' there, `before-string' would not be displayed?

>>> The question is what would you expect from the second example, if it
>>> used before-string there?  Should the before-string be displayed or
>>> shouldn't it?  Since invisible makes the beginning of the overlay
>>> disappear, under your suggestion it won't be displayed.

This doesn't seem to apply to the second example, because the overlay 
with `invisible' and the `display' prop start at the same position, so 
the beginning of the overlay would not be "made disappear".

I'm not sure what to do in the "mixed" cases like described above, 
though. Maybe only make `invisible' ignored when `display' covers the 
entirety of its span.

Or maybe this complexity is an argument in favor of `invisible' taking 
priority over `display', after all.

That sounds like it may be easier to implement, or at least specify: 
don't handle `display' only when it's entirely covered by `invisible'.

> You asked to ignore the invisible, so it will change.

Basically, my suggestion was to ignore it when `display' already 
performs all of its job. But the edge cases make it more complicated.





  reply	other threads:[~2014-08-24  1:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-17 22:35 bug#18285: 24.3.92; A combination of `display' on text and `invisible' and `before/after-string' leads to the before/after string being displayed twice Dmitry
     [not found] ` <handler.18285.B.140831493931056.ack@debbugs.gnu.org>
2014-08-18  1:06   ` bug#18285: Acknowledgement (24.3.92; A combination of `display' on text and `invisible' and `before/after-string' leads to the before/after string being displayed twice) Dmitry Gutov
2014-08-18 15:07 ` bug#18285: 24.3.92; A combination of `display' on text and `invisible' and `before/after-string' leads to the before/after string being displayed twice Eli Zaretskii
2014-08-21 14:07   ` Dmitry Gutov
2014-08-21 14:57     ` Eli Zaretskii
2014-08-21 15:40       ` Dmitry Gutov
2014-08-21 16:06         ` Eli Zaretskii
2014-08-22  0:58           ` Dmitry Gutov
2014-08-22  6:41             ` Eli Zaretskii
2014-08-22 11:41               ` Dmitry Gutov
2014-08-22 13:31                 ` Eli Zaretskii
2014-08-22 20:01                   ` Dmitry Gutov
2014-08-22 20:55                     ` Eli Zaretskii
2014-08-24  1:28                       ` Dmitry Gutov [this message]
2014-08-24  2:44                         ` Eli Zaretskii
2014-08-23 23:21     ` Dmitry Gutov
2014-08-24  2:40       ` Eli Zaretskii
2014-08-24  2:48         ` Dmitry Gutov
2022-04-18 11:39   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F93FCA.2040607@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=18285@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.