From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`. Date: Fri, 15 Aug 2014 17:52:25 +0200 Message-ID: <53EE2CB9.70206@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020209070204070701070300" X-Trace: ger.gmane.org 1408118056 31953 80.91.229.3 (15 Aug 2014 15:54:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Aug 2014 15:54:16 +0000 (UTC) Cc: 18215@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 15 17:54:04 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XIJpM-0003Qa-GJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Aug 2014 17:54:04 +0200 Original-Received: from localhost ([::1]:60221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIJpM-00066z-5Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Aug 2014 11:54:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIJoU-0004gH-Kz for bug-gnu-emacs@gnu.org; Fri, 15 Aug 2014 11:53:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIJoM-0001Uy-Vo for bug-gnu-emacs@gnu.org; Fri, 15 Aug 2014 11:53:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIJoM-0001Um-S8 for bug-gnu-emacs@gnu.org; Fri, 15 Aug 2014 11:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XIJoM-0008Ro-66 for bug-gnu-emacs@gnu.org; Fri, 15 Aug 2014 11:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Aug 2014 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18215-submit@debbugs.gnu.org id=B18215.140811796532424 (code B ref 18215); Fri, 15 Aug 2014 15:53:02 +0000 Original-Received: (at 18215) by debbugs.gnu.org; 15 Aug 2014 15:52:45 +0000 Original-Received: from localhost ([127.0.0.1]:44025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XIJo5-0008Qt-4u for submit@debbugs.gnu.org; Fri, 15 Aug 2014 11:52:45 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:61970) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XIJo3-0008QS-5k for 18215@debbugs.gnu.org; Fri, 15 Aug 2014 11:52:44 -0400 Original-Received: from [88.117.53.121] ([88.117.53.121]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MhRI2-1X4eo51mJ0-00MbmG; Fri, 15 Aug 2014 17:52:35 +0200 In-Reply-To: X-Provags-ID: V03:K0:85KmSCgFzf8gNdR7ttTD2AufYj6k4q9vNyBfND4Nof+qceQAIUB aghqfh4pMtD8GLMiFjVgHjwZQwxasRfX7xS42T7gd5sKJViwpqrIEWkjnZXt0AHS3Fr81fy 2PrnIAts5gRHsBnDXPKtP/aG3w8yvLkfuNHtdkt7t5+ZJhdgVYeGkCax6CkQoP+2fOdQcdE erHeODaTU+mdRzrT4nOlA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92482 Archived-At: This is a multi-part message in MIME format. --------------020209070204070701070300 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > I see no difference between the default behavior of August 13, 2014 Emacs Trunk (before applying the patch), versus after applying the August 12, 2014 patch of nsterm.m. I wasn't expecting too much from it anyway :-( > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > *window-frame-dump*_06_01_2014.txt > > frame pixel: 1926 x 1058 cols/lines: 174 x 52 units: 11 x 20 > frame text pixel: 1900 x 1054 cols/lines: 172 x 52 I suppose the 1926 is now 6 pixels too wide for a display width of 1920 and this comes from adding the 6 pixels for the changes in the fringe calculations. Correct? > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > *window_frame_dump*_08_13_2014.txt > > frame pixel: 1920 x 1058 cols/lines: 175 x 52 units: 11 x 20 > frame text pixel: 1900 x 1054 cols/lines: 172 x 52 Are these now the intended values? BTW have you set `frame-resize-pixelwise' to t? If you don't, Emacs will round sizes to character multiples. > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > Printout with `toggle-frame-maximzed` following Emacs -Q > > frame pixel: 1920 x 1000 cols/lines: 275 x 62 units: 7 x 16 > frame text pixel: 1885 x 996 cols/lines: 269 x 62 This means that the width isn't too far away from the other two but the height is quite different - maybe to account for a taskbar. I attach yet another patch for nsterm. You have to set `frame-resize-pixelwise' in your .emacs to some non-nil value for it (but you should have done that already as mentioned above). martin --------------020209070204070701070300 Content-Type: text/plain; charset=windows-1252; name="nsterm.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nsterm.diff" === modified file 'src/nsterm.m' --- src/nsterm.m 2014-07-27 14:45:26 +0000 +++ src/nsterm.m 2014-08-15 15:04:20 +0000 @@ -5840,9 +5840,18 @@ if (sz.width != FRAME_COLUMN_WIDTH (emacsframe) || sz.height != FRAME_LINE_HEIGHT (emacsframe)) { - sz.width = FRAME_COLUMN_WIDTH (emacsframe); - sz.height = FRAME_LINE_HEIGHT (emacsframe); - [win setResizeIncrements: sz]; + if (frame_resize_pixelwise) + { + sz.width = 1; + sz.height = 1; + } + else + { + sz.width = FRAME_COLUMN_WIDTH (emacsframe); + sz.height = FRAME_LINE_HEIGHT (emacsframe); + } + + [win setResizeIncrements: sz]; NSTRACE_SIZE ("New size", NSMakeSize (neww, newh)); } @@ -6111,8 +6120,17 @@ [win setDelegate: self]; [win useOptimizedDrawing: YES]; - sz.width = FRAME_COLUMN_WIDTH (f); - sz.height = FRAME_LINE_HEIGHT (f); + if (frame_resize_pixelwise) + { + sz.width = 1; + sz.height = 1; + } + else + { + sz.width = FRAME_COLUMN_WIDTH (f); + sz.height = FRAME_LINE_HEIGHT (f); + } + [win setResizeIncrements: sz]; [[win contentView] addSubview: self]; @@ -6459,8 +6477,16 @@ (FRAME_DEFAULT_FACE (f)), f); - sz.width = FRAME_COLUMN_WIDTH (f); - sz.height = FRAME_LINE_HEIGHT (f); + if (frame_resize_pixelwise) + { + sz.width = 1; + sz.height = 1; + } + else + { + sz.width = FRAME_COLUMN_WIDTH (f); + sz.height = FRAME_LINE_HEIGHT (f); + } if (fs_state != FULLSCREEN_BOTH) { --------------020209070204070701070300--