From: martin rudalics <rudalics@gmx.at>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 18215@debbugs.gnu.org
Subject: bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`.
Date: Fri, 15 Aug 2014 17:52:25 +0200 [thread overview]
Message-ID: <53EE2CB9.70206@gmx.at> (raw)
In-Reply-To: <m2egwjd9ai.wl%esq@lawlist.com>
[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]
> I see no difference between the default behavior of August 13, 2014 Emacs Trunk (before applying the patch), versus after applying the August 12, 2014 patch of nsterm.m.
I wasn't expecting too much from it anyway :-(
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>
> *window-frame-dump*_06_01_2014.txt
>
> frame pixel: 1926 x 1058 cols/lines: 174 x 52 units: 11 x 20
> frame text pixel: 1900 x 1054 cols/lines: 172 x 52
I suppose the 1926 is now 6 pixels too wide for a display width of 1920
and this comes from adding the 6 pixels for the changes in the fringe
calculations. Correct?
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>
> *window_frame_dump*_08_13_2014.txt
>
> frame pixel: 1920 x 1058 cols/lines: 175 x 52 units: 11 x 20
> frame text pixel: 1900 x 1054 cols/lines: 172 x 52
Are these now the intended values?
BTW have you set `frame-resize-pixelwise' to t? If you don't, Emacs
will round sizes to character multiples.
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>
> Printout with `toggle-frame-maximzed` following Emacs -Q
>
> frame pixel: 1920 x 1000 cols/lines: 275 x 62 units: 7 x 16
> frame text pixel: 1885 x 996 cols/lines: 269 x 62
This means that the width isn't too far away from the other two but the
height is quite different - maybe to account for a taskbar. I attach
yet another patch for nsterm. You have to set `frame-resize-pixelwise'
in your .emacs to some non-nil value for it (but you should have done
that already as mentioned above).
martin
[-- Attachment #2: nsterm.diff --]
[-- Type: text/plain, Size: 1632 bytes --]
=== modified file 'src/nsterm.m'
--- src/nsterm.m 2014-07-27 14:45:26 +0000
+++ src/nsterm.m 2014-08-15 15:04:20 +0000
@@ -5840,9 +5840,18 @@
if (sz.width != FRAME_COLUMN_WIDTH (emacsframe) ||
sz.height != FRAME_LINE_HEIGHT (emacsframe))
{
- sz.width = FRAME_COLUMN_WIDTH (emacsframe);
- sz.height = FRAME_LINE_HEIGHT (emacsframe);
- [win setResizeIncrements: sz];
+ if (frame_resize_pixelwise)
+ {
+ sz.width = 1;
+ sz.height = 1;
+ }
+ else
+ {
+ sz.width = FRAME_COLUMN_WIDTH (emacsframe);
+ sz.height = FRAME_LINE_HEIGHT (emacsframe);
+ }
+
+ [win setResizeIncrements: sz];
NSTRACE_SIZE ("New size", NSMakeSize (neww, newh));
}
@@ -6111,8 +6120,17 @@
[win setDelegate: self];
[win useOptimizedDrawing: YES];
- sz.width = FRAME_COLUMN_WIDTH (f);
- sz.height = FRAME_LINE_HEIGHT (f);
+ if (frame_resize_pixelwise)
+ {
+ sz.width = 1;
+ sz.height = 1;
+ }
+ else
+ {
+ sz.width = FRAME_COLUMN_WIDTH (f);
+ sz.height = FRAME_LINE_HEIGHT (f);
+ }
+
[win setResizeIncrements: sz];
[[win contentView] addSubview: self];
@@ -6459,8 +6477,16 @@
(FRAME_DEFAULT_FACE (f)),
f);
- sz.width = FRAME_COLUMN_WIDTH (f);
- sz.height = FRAME_LINE_HEIGHT (f);
+ if (frame_resize_pixelwise)
+ {
+ sz.width = 1;
+ sz.height = 1;
+ }
+ else
+ {
+ sz.width = FRAME_COLUMN_WIDTH (f);
+ sz.height = FRAME_LINE_HEIGHT (f);
+ }
if (fs_state != FULLSCREEN_BOTH)
{
next prev parent reply other threads:[~2014-08-15 15:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 18:40 bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame` Keith David Bershatsky
2014-08-08 8:45 ` martin rudalics
2014-08-09 19:29 ` Keith David Bershatsky
2014-08-10 9:19 ` martin rudalics
2014-08-09 19:36 ` bug#18215: Fwd: " Keith David Bershatsky
2014-08-09 19:37 ` Keith David Bershatsky
2014-08-09 20:00 ` Keith David Bershatsky
2014-08-10 16:51 ` Keith David Bershatsky
2014-08-11 7:40 ` martin rudalics
2014-08-12 2:47 ` Keith David Bershatsky
2014-08-12 13:03 ` martin rudalics
2014-08-13 4:43 ` Keith David Bershatsky
2014-08-13 6:23 ` martin rudalics
2014-08-13 10:33 ` Jan D.
2014-08-13 12:21 ` martin rudalics
2014-08-13 4:49 ` Keith David Bershatsky
2014-08-14 3:44 ` Keith David Bershatsky
2014-08-15 15:52 ` martin rudalics [this message]
2014-08-16 23:35 ` Keith David Bershatsky
2014-08-17 10:12 ` martin rudalics
2014-08-17 18:29 ` Keith David Bershatsky
2014-08-18 8:31 ` martin rudalics
2017-09-02 17:44 ` bug#18215: [PATCH] Set frame size to actual requested size (bug#18215) Alan Third
[not found] <m24mxnknho.wl%esq@lawlist.com>
2014-08-09 9:44 ` bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame` martin rudalics
[not found] <m2ha1l4nxl.wl%esq@lawlist.com>
2014-08-09 17:14 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE2CB9.70206@gmx.at \
--to=rudalics@gmx.at \
--cc=18215@debbugs.gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.