bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`.

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

 > I see no difference between the default behavior of August 13, 2014 Emacs Trunk (before applying the patch), versus after applying the August 12, 2014 patch of nsterm.m.

I wasn't expecting too much from it anyway :-(

 > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 >
 > *window-frame-dump*_06_01_2014.txt
 >
 > frame pixel: 1926 x 1058   cols/lines: 174 x 52   units: 11 x 20
 > frame text pixel: 1900 x 1054   cols/lines: 172 x 52

I suppose the 1926 is now 6 pixels too wide for a display width of 1920
and this comes from adding the 6 pixels for the changes in the fringe
calculations.  Correct?

 > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 >
 > *window_frame_dump*_08_13_2014.txt
 >
 > frame pixel: 1920 x 1058   cols/lines: 175 x 52   units: 11 x 20
 > frame text pixel: 1900 x 1054   cols/lines: 172 x 52

Are these now the intended values?

BTW have you set `frame-resize-pixelwise' to t?  If you don't, Emacs
will round sizes to character multiples.

 > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 >
 > Printout with `toggle-frame-maximzed` following Emacs -Q
 >
 > frame pixel: 1920 x 1000   cols/lines: 275 x 62   units: 7 x 16
 > frame text pixel: 1885 x 996   cols/lines: 269 x 62

This means that the width isn't too far away from the other two but the
height is quite different - maybe to account for a taskbar.  I attach
yet another patch for nsterm.  You have to set `frame-resize-pixelwise'
in your .emacs to some non-nil value for it (but you should have done
that already as mentioned above).

martin

[-- Attachment #2: nsterm.diff --]
[-- Type: text/plain, Size: 1632 bytes --]

=== modified file 'src/nsterm.m'
--- src/nsterm.m	2014-07-27 14:45:26 +0000
+++ src/nsterm.m	2014-08-15 15:04:20 +0000
@@ -5840,9 +5840,18 @@
       if (sz.width != FRAME_COLUMN_WIDTH (emacsframe) ||
           sz.height != FRAME_LINE_HEIGHT (emacsframe))
         {
-          sz.width = FRAME_COLUMN_WIDTH (emacsframe);
-          sz.height = FRAME_LINE_HEIGHT (emacsframe);
-          [win setResizeIncrements: sz];
+          if (frame_resize_pixelwise)
+	    {
+	      sz.width = 1;
+	      sz.height = 1;
+	    }
+	  else
+	    {
+	      sz.width = FRAME_COLUMN_WIDTH (emacsframe);
+	      sz.height = FRAME_LINE_HEIGHT (emacsframe);
+	    }
+
+	  [win setResizeIncrements: sz];

           NSTRACE_SIZE ("New size", NSMakeSize (neww, newh));
         }
@@ -6111,8 +6120,17 @@
   [win setDelegate: self];
   [win useOptimizedDrawing: YES];

-  sz.width = FRAME_COLUMN_WIDTH (f);
-  sz.height = FRAME_LINE_HEIGHT (f);
+  if (frame_resize_pixelwise)
+    {
+      sz.width = 1;
+      sz.height = 1;
+    }
+  else
+    {
+      sz.width = FRAME_COLUMN_WIDTH (f);
+      sz.height = FRAME_LINE_HEIGHT (f);
+    }
+
   [win setResizeIncrements: sz];

   [[win contentView] addSubview: self];
@@ -6459,8 +6477,16 @@
                                  (FRAME_DEFAULT_FACE (f)),
                                  f);

-  sz.width = FRAME_COLUMN_WIDTH (f);
-  sz.height = FRAME_LINE_HEIGHT (f);
+  if (frame_resize_pixelwise)
+    {
+      sz.width = 1;
+      sz.height = 1;
+    }
+  else
+    {
+      sz.width = FRAME_COLUMN_WIDTH (f);
+      sz.height = FRAME_LINE_HEIGHT (f);
+    }

   if (fs_state != FULLSCREEN_BOTH)
     {