From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`. Date: Mon, 11 Aug 2014 09:40:04 +0200 Message-ID: <53E87354.4050201@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060805000007040501030007" X-Trace: ger.gmane.org 1407742895 30389 80.91.229.3 (11 Aug 2014 07:41:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2014 07:41:35 +0000 (UTC) Cc: 18215@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 11 09:41:28 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XGkEM-0001wZ-Pu for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2014 09:41:23 +0200 Original-Received: from localhost ([::1]:34235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGkEL-0007XA-NN for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2014 03:41:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGkEB-0007Vy-Oe for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 03:41:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGkE2-0007KH-JI for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 03:41:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGkE2-0007KD-FU for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 03:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XGkE1-0001DZ-VQ for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2014 03:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Aug 2014 07:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18215-submit@debbugs.gnu.org id=B18215.14077428224621 (code B ref 18215); Mon, 11 Aug 2014 07:41:01 +0000 Original-Received: (at 18215) by debbugs.gnu.org; 11 Aug 2014 07:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:38434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGkDN-0001CQ-FS for submit@debbugs.gnu.org; Mon, 11 Aug 2014 03:40:21 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58385) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGkDL-0001CD-Bx for 18215@debbugs.gnu.org; Mon, 11 Aug 2014 03:40:20 -0400 Original-Received: from [178.191.138.180] ([178.191.138.180]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MD9q8-1XBCq40sE0-00GYPM; Mon, 11 Aug 2014 09:40:08 +0200 In-Reply-To: X-Provags-ID: V03:K0:q8CoY3Qf7oWrJABOeYW6gAA6jOnHDGxJXq5FabLMejyfoMjDP/e k48HAg49XOyO90ahbLqICAEUoXALWE2Qa+5j3oit/xNkqLy+WVXvSVePyUBKv2fmF3Z8jI3 GJ2/87SYsF2ddfldUQ6D7cHJxgJlZSSWgdJadZluYdHm/FSBYO4tRjTmjpQMyAUvElBMCwO 4EokgR9Rub7L2jH79SSqQ== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92410 Archived-At: This is a multi-part message in MIME format. --------------060805000007040501030007 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > With both Emacs versions (i.e., June 1, 2014 and the patched August 8, > 2014) and a setting of `(setq ns-auto-hide-menu-bar t)`, the function > `toggle-frame-maximized` leaves approximately 10 pixels at the top of > the screen that are not filled and about 4 or more pixels to the right > of the screen that are not filled. The only method that I have > discovered that can fill the screen entirely (without going into > full-screen mode), is using `set-frame-size` with the pixelwise > argument. When not using `(setq ns-auto-hide-menu-bar t)`, there are > still a few pixels that are not filled by the Emacs frame when using > `toggle-frame-maximized`. I suppose the missing 10/4 pixels are from trying to constrain the size of the frame to multiples of Emacs' character sizes. What happens when you disable that as in the attached patch? martin --------------060805000007040501030007 Content-Type: text/plain; charset=windows-1252; name="nsterm.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nsterm.diff" --- src/nsterm.m 2014-08-11 08:37:20.734375000 +0200 *************** *** 5842,5848 **** { sz.width = FRAME_COLUMN_WIDTH (emacsframe); sz.height = FRAME_LINE_HEIGHT (emacsframe); ! [win setResizeIncrements: sz]; NSTRACE_SIZE ("New size", NSMakeSize (neww, newh)); } --- 5842,5848 ---- { sz.width = FRAME_COLUMN_WIDTH (emacsframe); sz.height = FRAME_LINE_HEIGHT (emacsframe); ! /// [win setResizeIncrements: sz]; NSTRACE_SIZE ("New size", NSMakeSize (neww, newh)); } *************** *** 6113,6119 **** sz.width = FRAME_COLUMN_WIDTH (f); sz.height = FRAME_LINE_HEIGHT (f); ! [win setResizeIncrements: sz]; [[win contentView] addSubview: self]; --- 6113,6119 ---- sz.width = FRAME_COLUMN_WIDTH (f); sz.height = FRAME_LINE_HEIGHT (f); ! /// [win setResizeIncrements: sz]; [[win contentView] addSubview: self]; *************** *** 6499,6505 **** [fw setDelegate:self]; [fw setAcceptsMouseMovedEvents: YES]; [fw useOptimizedDrawing: YES]; ! [fw setResizeIncrements: sz]; [fw setBackgroundColor: col]; if ([col alphaComponent] != (EmacsCGFloat) 1.0) [fw setOpaque: NO]; --- 6499,6505 ---- [fw setDelegate:self]; [fw setAcceptsMouseMovedEvents: YES]; [fw useOptimizedDrawing: YES]; ! /// [fw setResizeIncrements: sz]; [fw setBackgroundColor: col]; if ([col alphaComponent] != (EmacsCGFloat) 1.0) [fw setOpaque: NO]; *************** *** 6537,6543 **** } [w setContentView:[fw contentView]]; ! [w setResizeIncrements: sz]; [w setBackgroundColor: col]; if ([col alphaComponent] != (EmacsCGFloat) 1.0) [w setOpaque: NO]; --- 6537,6543 ---- } [w setContentView:[fw contentView]]; ! /// [w setResizeIncrements: sz]; [w setBackgroundColor: col]; if ([col alphaComponent] != (EmacsCGFloat) 1.0) [w setOpaque: NO]; --------------060805000007040501030007--