From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around Date: Mon, 04 Aug 2014 12:28:19 +0400 Message-ID: <53DF4423.6050101@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1407140971 5314 80.91.229.3 (4 Aug 2014 08:29:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2014 08:29:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 04 10:29:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XEDdz-0004H3-Oj for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2014 10:29:23 +0200 Original-Received: from localhost ([::1]:50961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEDdv-0007n6-6R for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2014 04:29:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEDdA-0006R2-Oo for emacs-devel@gnu.org; Mon, 04 Aug 2014 04:28:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEDd3-0007jq-Bx for emacs-devel@gnu.org; Mon, 04 Aug 2014 04:28:32 -0400 Original-Received: from forward16.mail.yandex.net ([95.108.253.141]:44129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEDd3-0007jI-1v for emacs-devel@gnu.org; Mon, 04 Aug 2014 04:28:25 -0400 Original-Received: from smtp17.mail.yandex.net (smtp17.mail.yandex.net [95.108.252.17]) by forward16.mail.yandex.net (Yandex) with ESMTP id 9C3A3D2107C; Mon, 4 Aug 2014 12:28:22 +0400 (MSK) Original-Received: from smtp17.mail.yandex.net (localhost [127.0.0.1]) by smtp17.mail.yandex.net (Yandex) with ESMTP id 436821900553; Mon, 4 Aug 2014 12:28:22 +0400 (MSK) Original-Received: from mail.dev.rtsoft.ru (mail.dev.rtsoft.ru [213.79.90.226]) by smtp17.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Xf5ghi6hvK-SLpei3Q9; Mon, 4 Aug 2014 12:28:21 +0400 (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: c65dcb99-71db-42b7-b95e-1158cf025fff DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1407140901; bh=3b0y72hjx7KcTWp4XuVfqE09NhvLIoTaVIS6UodauTU=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=geYWiINxB0JUj1rL5o7a+NkjJ/DnxaudFkUTpGi5clOEt3jltTpaMmEyW5b6quQ4e tq2CmWCLOP7a+Xjw3sB1UruqObGznQSIuJQzMrj3Uj0iP+OzIDm+danEksjUpZanMk 9kDGKrr/fO491IGWEbCK5HBNlGtEjyx2dAf4PKAg= Authentication-Results: smtp17.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 95.108.253.141 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173411 Archived-At: On 08/04/2014 11:28 AM, Stefan Monnier wrote: > You remove the comment but don't fix the code accordingly: if the FIXME > is not valid any more, than we should cleanly pass `hook' as argument > rather than let-binding it to inhibit-quit. Hm...isn't it required to bind inhibit-quit to non-nil value before running hooks? Dmitry