From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme Date: Tue, 29 Jul 2014 16:02:13 +0200 Message-ID: <53D7A965.30700@gmx.at> References: <87d2cpxaq1.fsf@holos.localdomain> <8338dkh6wo.fsf@gnu.org> <53D77B06.8040907@gmx.at> <83tx60fjnh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1406642624 18329 80.91.229.3 (29 Jul 2014 14:03:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2014 14:03:44 +0000 (UTC) Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 29 16:03:39 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XC806-0001p7-G9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 16:03:34 +0200 Original-Received: from localhost ([::1]:45934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC805-000535-TZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 10:03:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC7zi-0004Zq-VB for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 10:03:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC7za-00024k-HP for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 10:03:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC7za-00024d-EH for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 10:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XC7za-0001xt-5k for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jul 2014 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18136-submit@debbugs.gnu.org id=B18136.14066425617524 (code B ref 18136); Tue, 29 Jul 2014 14:03:02 +0000 Original-Received: (at 18136) by debbugs.gnu.org; 29 Jul 2014 14:02:41 +0000 Original-Received: from localhost ([127.0.0.1]:42164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XC7zA-0001xE-BM for submit@debbugs.gnu.org; Tue, 29 Jul 2014 10:02:40 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:53951) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XC7z4-0001wt-I2 for 18136@debbugs.gnu.org; Tue, 29 Jul 2014 10:02:35 -0400 Original-Received: from [62.46.213.117] ([62.46.213.117]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Mhej1-1WpOIw1jJD-00MtRk; Tue, 29 Jul 2014 16:02:21 +0200 In-Reply-To: <83tx60fjnh.fsf@gnu.org> X-Provags-ID: V03:K0:Q8y5KnbZTVAhntiDLZT3pE2xjfDHIo/wBCPd39KTBRZZ6FXCTc9 N/4hBFx4UEUohNw/7U8ZD81VmjlpMA5b8VxuzudokpmPdO27RnW75DgXkkoY5OrETn6kiRi JhnimB0RkT9Uu2BjcQzYY4h704cyUKoZj1s6wsAeUFwJr1Ws1z53KQjlE1LGmQwwIOartoW v4GRkUV3SVELvWf7in1Sg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91942 Archived-At: > Why does it make sense to do that for TTY frames? The terminal screen > cannot be resized from within Emacs, so the arguments for treating the > menu bar as an add-on are not really valid in this case. The idea is that `frame-height' should have the same semantics on all platforms. If you think we can ignore this difference for TTY frames I'm obviously OK with it. > Please ask questions about what you don't understand. Having just > completed a debugging session for bug #18112, which was all about > assignment of TTY frame sizes, I think I can explain at least some of > that. > >> Probably this assignment >> >> if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f)) >> FrameCols (FRAME_TTY (f)) = new_cols; >> >> is completely misplaced and should be either removed or inhibited when >> called from change_frame_size_1, that is when INHIBIT equals 5. Can you >> tell me what this assignment is for? > > It cannot be removed or inhibited. Inhibited exclusively for the case that this function is called from change_frame_size (that is when INHIBIT equals 5). > It was introduced to fix a bug > (#17875). The problem is that different TTY frames on the same > terminal can potentially have different dimensions, and OTOH FrameCols > and FrameRows are "normally" set only at terminal initiation and in > response to a SIGWINCH signal. These assignments take care of keeping > FrameCols and FrameRows in sync with frame dimensions in all other > cases, because they all go through change_frame_size. Which means FrameCols and FrameRows always have the correct values when entering adjust_frame_size and we shouldn't change them there. Or am I missing something? martin