From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan Chaloupka Newsgroups: gmane.emacs.bugs Subject: bug#18140: [PATCH] macros.c: CHECK_VECTOR_OR_STRING invokes wrong_type_argument for Qnil instead of return 0 Date: Tue, 29 Jul 2014 11:59:38 +0200 Message-ID: <53D7708A.9010007@redhat.com> References: <20140729053056.14713.45327.stgit@unused-4-157.brq.redhat.com> <53D73287.6020406@redhat.com> <53D75A18.8000508@redhat.com> <53D76178.6000908@redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1406628096 26403 80.91.229.3 (29 Jul 2014 10:01:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2014 10:01:36 +0000 (UTC) To: 18140@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 29 12:01:28 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XC4Do-0000qi-MT for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 12:01:28 +0200 Original-Received: from localhost ([::1]:44478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4Dj-0003iY-98 for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Jul 2014 06:01:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4DX-0003hR-4G for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 06:01:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC4DO-00029K-3W for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 06:01:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4DO-00029E-0F for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 06:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XC4DN-0001xR-JU for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 06:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan Chaloupka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jul 2014 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18140 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14066280237475 (code B ref -1); Tue, 29 Jul 2014 10:01:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jul 2014 10:00:23 +0000 Original-Received: from localhost ([127.0.0.1]:41629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XC4Cg-0001wL-Gb for submit@debbugs.gnu.org; Tue, 29 Jul 2014 06:00:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59939) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XC4CZ-0001vF-AH for submit@debbugs.gnu.org; Tue, 29 Jul 2014 06:00:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC4CL-0001l3-13 for submit@debbugs.gnu.org; Tue, 29 Jul 2014 06:00:06 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4CK-0001kz-UR for submit@debbugs.gnu.org; Tue, 29 Jul 2014 05:59:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4CD-0003Zs-Et for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 05:59:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC4C5-0001k8-Vc for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 05:59:49 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:50365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC4C5-0001k1-OW for bug-gnu-emacs@gnu.org; Tue, 29 Jul 2014 05:59:41 -0400 Original-Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6T9xdrE001484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jul 2014 05:59:40 -0400 Original-Received: from unused-4-157.brq.redhat.com (unused-4-228.brq.redhat.com [10.34.4.228]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6T9xcGI014281 for ; Tue, 29 Jul 2014 05:59:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91925 Archived-At: On 07/29/2014 11:04 AM, Andreas Schwab wrote: > Jan Chaloupka writes: > >> So is it correct if append and Vlast_kbd_macro are both Qnil resulting in >> CHECK_VECTOR_OR_STRING fail? > Sure, that's the point of the check. last-kbd-macro is a lisp-level > variable, so it must be checked. Yes, I agree it has to be check. Having .emacs.desktop file with series of the folkowing kbd macro definitions: (desktop-create-buffer 206 ... '(defining-kbd-macro global-auto-revert-mode) ... ) append argument of start-kbd-macro is false. But because there is no last kbd macro, check fails. I guess then .emacs.desktop is incorectly written. Thus resulting in proper check fail. >> Because Vlast_kbd_macro is not VECTOR nor STRING > That just calls error, but not emacs_abort. CHECK_VECTOR_OR_STRING -> wrong_type_argument -> xsignal2 -> xsignal void xsignal (Lisp_Object error_symbol, Lisp_Object data) { Fsignal (error_symbol, data); emacs_abort (); } emacs_abort then has to be called after Fsignal finished. Or is there a back jmp back to main loop or somewhere else? > Andreas. >