From: Jan Chaloupka <jchaloup@redhat.com>
To: 18140@debbugs.gnu.org
Subject: bug#18140: [PATCH] macros.c: CHECK_VECTOR_OR_STRING invokes wrong_type_argument for Qnil instead of return 0
Date: Tue, 29 Jul 2014 11:59:38 +0200 [thread overview]
Message-ID: <53D7708A.9010007@redhat.com> (raw)
In-Reply-To: <mvm38dkh6x8.fsf@hawking.suse.de>
On 07/29/2014 11:04 AM, Andreas Schwab wrote:
> Jan Chaloupka <jchaloup@redhat.com> writes:
>
>> So is it correct if append and Vlast_kbd_macro are both Qnil resulting in
>> CHECK_VECTOR_OR_STRING fail?
> Sure, that's the point of the check. last-kbd-macro is a lisp-level
> variable, so it must be checked.
Yes, I agree it has to be check. Having .emacs.desktop file with series
of the folkowing kbd macro definitions:
(desktop-create-buffer 206
...
'(defining-kbd-macro global-auto-revert-mode)
...
)
append argument of start-kbd-macro is false. But because there is no
last kbd macro,
check fails. I guess then .emacs.desktop is incorectly written. Thus
resulting in
proper check fail.
>> Because Vlast_kbd_macro is not VECTOR nor STRING
> That just calls error, but not emacs_abort.
CHECK_VECTOR_OR_STRING -> wrong_type_argument -> xsignal2 -> xsignal
void
xsignal (Lisp_Object error_symbol, Lisp_Object data)
{
Fsignal (error_symbol, data);
emacs_abort ();
}
emacs_abort then has to be called after Fsignal finished. Or is there a
back jmp back to main loop or somewhere else?
> Andreas.
>
next prev parent reply other threads:[~2014-07-29 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140729053056.14713.45327.stgit@unused-4-157.brq.redhat.com>
2014-07-29 5:35 ` bug#18140: [PATCH] macros.c: CHECK_VECTOR_OR_STRING invokes wrong_type_argument for Qnil instead of return 0 Jan Chaloupka
2014-07-29 7:52 ` Andreas Schwab
2014-07-29 8:23 ` Jan Chaloupka
2014-07-29 8:37 ` Andreas Schwab
2014-07-29 8:55 ` Jan Chaloupka
2014-07-29 9:04 ` Andreas Schwab
2014-07-29 9:59 ` Jan Chaloupka [this message]
2014-07-29 10:05 ` Andreas Schwab
2014-07-29 8:10 ` Andreas Schwab
[not found] <20140728103721.7115.54163.stgit@unused-4-157.brq.redhat.com>
2014-07-29 5:01 ` Jan Chaloupka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7708A.9010007@redhat.com \
--to=jchaloup@redhat.com \
--cc=18140@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.