From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Changes in frame/window code Date: Wed, 23 Jul 2014 14:48:00 +0200 Message-ID: <53CFAF00.5080705@gmx.at> References: <53CE6A44.1010708@gmx.at> <53CF9245.7080209@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1406119716 1508 80.91.229.3 (23 Jul 2014 12:48:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2014 12:48:36 +0000 (UTC) Cc: emacs-devel To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 23 14:48:29 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X9vy7-0004K2-MA for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2014 14:48:27 +0200 Original-Received: from localhost ([::1]:44422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9vy7-0007d8-Bq for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2014 08:48:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9vxx-0007cs-Do for emacs-devel@gnu.org; Wed, 23 Jul 2014 08:48:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9vxp-00008R-LM for emacs-devel@gnu.org; Wed, 23 Jul 2014 08:48:17 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:58330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9vxp-00008L-9k for emacs-devel@gnu.org; Wed, 23 Jul 2014 08:48:09 -0400 Original-Received: from [188.22.43.250] ([188.22.43.250]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M1n4s-1WGJCu2cws-00tiLr; Wed, 23 Jul 2014 14:48:06 +0200 In-Reply-To: <53CF9245.7080209@yandex.ru> X-Provags-ID: V03:K0:tlBsdKl4wAt5eCkoXbELEarBnawZpghet3yIGXebRj8PIwER7jC ce5Z7qQT3evhMBWVC8/jjxv164oW1GBJ6AbfU3LPhYmOWLiQAwkANduodOZ5iLUvR4xCrUu UjJRJm0O8BWPiWxq+VrIVIV0HVU6bdBf643vV/iG4DMv89j4BYDvCF8uZCnXJ2oBBcWbH7V 9wzheX3a5vnuNRHFVOXsA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173094 Archived-At: >> (2) Fix the "toolbar/menubar height is part of the frame text height" >> issue (which the recent change in revision 117561 doesn't). > > What's wrong with that? With emacs -Q and an internal tool bar evaluate one after the other (frame-height) (set-frame-height nil (1+ (frame-height))) (frame-height) Here the `set-frame-height' shrinks the frame. > 0) Debug stubs (Vmy_debug_it in widget.c)? Thanks for spotting them. I have created the patch on Windows, so this is indeed a leftover from the GNU/Linux platform debugging code. > 1) It doesn't even compile with --enable-gcc-warnings (didn't you use it for > development?) On GNU/Linux I always compile with --enable-gcc-warnings=yes --enable-checking=yes --enable-check-lisp-object-type=yes > due to missing 'x_clear_under_internal_border' prototype. Sorry. It's in xterm.h here (and thusly also mentioned in the ChangeLog) but got lost in the transition to my Windows machine. > 2) It crashes with both Lucid and Motif (after a few attempts to toggle > with M-x horizontal-scroll-bar-mode and drag): > #0 0x000000379220f62b in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:37 > #1 0x000000000056bcbc in terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at ../../trunk/src/emacs.c:387 > #2 0x00000000005f406d in die (msg=0x70acfe "VECTORLIKEP (a)", file=0x70acb8 "../../trunk/src/lisp.h", line=866) > at ../../trunk/src/alloc.c:7102 > #3 0x0000000000566ba5 in XVECTOR (a=...) at ../../trunk/src/lisp.h:866 > #4 0x0000000000538106 in xt_action_hook (widget=0xd10060, client_data=0x0, action_name=0x138e2ec "EndScroll", event=0x7fffd5134100, > params=0x0, num_params=0x372f066290 ) at ../../trunk/src/xterm.c:4248 I can't reproduce that here - what precisely means "toggle with M-x horizontal-scroll-bar-mode and drag"? Dragging the slider with the mouse? Do you have to toggle more than once to make the bug happen? Do you have any interpretation for what happened? > 3) On Lucid, scroll bars are of the different colors (see screenshot). I can't see such a thing here. Is this with Xaw3D? Thanks for the feedback, martin