From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#18006: Simplify via set_binary_mode Date: Tue, 15 Jul 2014 12:39:36 -0700 Organization: UCLA Computer Science Department Message-ID: <53C58378.2000405@cs.ucla.edu> References: <53C1A00C.6050906@cs.ucla.edu> <837g3hanzp.fsf@gnu.org> <53C21918.9020001@cs.ucla.edu> <8338e59u9u.fsf@gnu.org> <53C33C6A.6060601@cs.ucla.edu> <83pph87ype.fsf@gnu.org> <53C43A86.4070303@cs.ucla.edu> <83egxm8z7v.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1405453232 3016 80.91.229.3 (15 Jul 2014 19:40:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Jul 2014 19:40:32 +0000 (UTC) Cc: 18006-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 15 21:40:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X78aN-0004eg-4U for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Jul 2014 21:40:23 +0200 Original-Received: from localhost ([::1]:36356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X78aM-0003pW-Kx for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Jul 2014 15:40:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X78aB-0003nU-PC for bug-gnu-emacs@gnu.org; Tue, 15 Jul 2014 15:40:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X78a4-0001wG-8v for bug-gnu-emacs@gnu.org; Tue, 15 Jul 2014 15:40:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X78a4-0001vw-6r for bug-gnu-emacs@gnu.org; Tue, 15 Jul 2014 15:40:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X78a3-0003hg-RT for bug-gnu-emacs@gnu.org; Tue, 15 Jul 2014 15:40:03 -0400 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jul 2014 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 18006@debbugs.gnu.org, eggert@cs.ucla.edu, eggert@cs.ucla.edu Original-Received: via spool by 18006-done@debbugs.gnu.org id=D18006.140545319414211 (code D ref 18006); Tue, 15 Jul 2014 19:40:02 +0000 Original-Received: (at 18006-done) by debbugs.gnu.org; 15 Jul 2014 19:39:54 +0000 Original-Received: from localhost ([127.0.0.1]:55833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X78Zt-0003h9-JV for submit@debbugs.gnu.org; Tue, 15 Jul 2014 15:39:53 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:45946) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X78Zs-0003gw-Ac for 18006-done@debbugs.gnu.org; Tue, 15 Jul 2014 15:39:52 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 22491A60007; Tue, 15 Jul 2014 12:39:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jgvBrMQtFrN8; Tue, 15 Jul 2014 12:39:37 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 470FF39E801B; Tue, 15 Jul 2014 12:39:37 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: <83egxm8z7v.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91571 Archived-At: Eli Zaretskii wrote: > The lib-src part looks OK to me. Thanks, I installed that. > This part doesn't look right. If we don't use "rt", then when > emacs_fopen calls emacs_open Ah, sorry, that part was a false alarm. I forgot that emacs_fopen doesn't pass the mode string to fopen, which means there's no portability bug there after all. If we were going to make a change I'd prefer your (a) to your (b) as it keeps the mainline code simpler, but doing nothing at all is simpler yet, so I'll close the bug.