all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: raeburn@permabit.com, 17975@debbugs.gnu.org
Subject: bug#17975: 24.3.92; assertion failure deleting frames with varying names for the same	display (and, using multiple X11 connections in that case too)
Date: Sun, 13 Jul 2014 19:54:15 +0400	[thread overview]
Message-ID: <53C2ABA7.9080907@yandex.ru> (raw)
In-Reply-To: <831ttp9u73.fsf@gnu.org>

On 07/13/2014 07:04 PM, Eli Zaretskii wrote:

> Does it help to avoid calling update_menu_bar for frames that don't
> pass the FRAME_LIVE_P test?

If you mean just this:

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2014-07-12 17:53:29 +0000
+++ src/xdisp.c	2014-07-13 15:32:01 +0000
@@ -11698,7 +11698,8 @@
  	    }

  	  GCPRO1 (tail);
-	  menu_bar_hooks_run = update_menu_bar (f, 0, menu_bar_hooks_run);
+	  if (FRAME_LIVE_P (f))
+	    menu_bar_hooks_run = update_menu_bar (f, 0, menu_bar_hooks_run);
  #ifdef HAVE_WINDOW_SYSTEM
  	  update_tool_bar (f, 0);
  #endif

then no, at least for Ken's test case.

Dmitry






  reply	other threads:[~2014-07-13 15:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 19:59 bug#17975: 24.3.92; assertion failure deleting frames with varying names for the same display (and, using multiple X11 connections in that case too) Ken Raeburn
2014-07-09  5:37 ` Dmitry Antipov
2014-07-11 21:22   ` Ken Raeburn
2014-07-13  5:43     ` Dmitry Antipov
2014-07-13 10:49       ` Dmitry Antipov
2014-07-13 10:56         ` Dmitry Antipov
2014-07-13 15:04           ` Eli Zaretskii
2014-07-13 15:54             ` Dmitry Antipov [this message]
2014-07-13 16:35               ` Eli Zaretskii
2014-07-13 18:01                 ` Dmitry Antipov
2014-07-13 18:28                   ` Eli Zaretskii
2014-07-14  5:20                     ` Dmitry Antipov
2020-09-09 11:35           ` Lars Ingebrigtsen
2020-09-09 11:28         ` Lars Ingebrigtsen
2020-09-11 10:11           ` Dmitry Antipov
2020-09-11 12:54             ` Lars Ingebrigtsen
2020-09-11 13:01               ` Eli Zaretskii
2014-07-14  5:13       ` Ken Raeburn
2014-07-14  7:23         ` Dmitry Antipov
2014-07-14  8:10           ` Jan Djärv
2014-07-14 10:19             ` Dmitry Antipov
2014-07-14 18:58               ` Ken Raeburn
2016-04-13 18:19 ` Ken Raeburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C2ABA7.9080907@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=17975@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=raeburn@permabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.