all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>, Stephen Hassard <steve@hassard.net>
Cc: 17971@debbugs.gnu.org
Subject: bug#17971: 24.3.92; Patch to fix el compression on RHEL/CentOS 7
Date: Thu, 10 Jul 2014 10:14:43 -0700	[thread overview]
Message-ID: <53BECA03.9010509@cs.ucla.edu> (raw)
In-Reply-To: <fo8uo1mc4y.fsf@fencepost.gnu.org>

Glenn Morris wrote:

> My inclination is to revert install-arch-indep to how it used to be
> before 2014-02-13.

The patch you proposed is a simplification of the pre-2014-02-13 code, a 
simplification that should also avoid the HP-UX problm.  (HP-UX make is 
still relevant for the emacs-24 branch, I guess.)

> ! 	  cd "$(DESTDIR)${lispdir}" || exit 1 ; \
> ! 	  for f in `find . -name "*.elc" -print`; do \
> ! 	    f_el=`echo "$$f" | sed 's/.elc$$/.el/'`; \
> ! 	    ${GZIP_PROG} -9n "$$f_el" ; \
> ! 	  done ; \

This has the problem that 'make' can succeed even if a 'gzip' fails 
(e.g., due to being out of disk space).  Also, it can be simplified a 
bit.  How about something like this instead?

	  cd "$(DESTDIR)${lispdir}" && \
  	  for f in `find . -name '*.elc' -print | sed 's/.elc$$/.el/'`; do \
	    ${GZIP_PROG} -9n "$$f" || exit; \
	  done; \





  reply	other threads:[~2014-07-10 17:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08  5:05 bug#17971: 24.3.92; Patch to fix el compression on RHEL/CentOS 7 Stephen Hassard
2014-07-08  6:04 ` Glenn Morris
2014-07-08 15:50   ` Stephen Hassard
2014-07-09  1:10     ` Glenn Morris
2014-07-09  4:07       ` Stephen Hassard
2014-07-09  4:16         ` Stephen Hassard
2014-07-09 13:56           ` Stephen Hassard
2014-07-09 16:34           ` Glenn Morris
2014-07-09 17:29             ` Stephen Hassard
2014-07-10 16:06               ` Glenn Morris
2014-07-10 17:14                 ` Paul Eggert [this message]
2014-07-10 18:06                   ` Glenn Morris
2014-07-10 18:49                     ` Paul Eggert
2014-07-11  6:37                 ` Paul Eggert
     [not found]                   ` <CAAicSydhXppOY=uqe90yZNDMszY5VnJb632FZWH6NzJe+bH9Zg@mail.gmail.com>
2014-07-11 17:36                     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BECA03.9010509@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=17971@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    --cc=steve@hassard.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.