bug#17951: Subword-mode should support shift selection in and out of cua-mode

bug#17951: Subword-mode should support shift selection in and out of cua-mode

[Matthew Fidler]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

Subword movement funtions should be specified as

(interactive "^p") instead of (interactive "p") to allow shift selection.

When cua-mode is enabled, shift-selection is also enabled since all the
functions have

(put 'subword-forward 'CUA 'move)
so, I think it should be consistent.
Just my 2 cents.

Matt

[-- Attachment #2: Type: text/html, Size: 434 bytes --]

bug#17951: Subword-mode should support shift selection in and out of cua-mode

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

On 07/05/2014 09:31 PM, Matthew Fidler wrote:
> Subword movement funtions should be specified as
> 
> (interactive "^p") instead of (interactive "p") to allow shift selection. 
> 
> When cua-mode is enabled, shift-selection is also enabled since all the
> functions have
> 
> (put 'subword-forward 'CUA 'move)
> 
> so, I think it should be consistent.
> Just my 2 cents.

In trunk, subword-word changes the definition of a word instead of
trying to rebind movement commands. All the shift-motion stuff should
just work in the new implementation.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

bug#17951: Subword-mode should support shift selection in and out of cua-mode

[Stefan Monnier]

>> Subword movement funtions should be specified as
>> (interactive "^p") instead of (interactive "p") to allow shift selection. 

AFAICT this is already the case in 24.3.92 (but yes, it was missing in
24.3).

>> When cua-mode is enabled, shift-selection is also enabled since all the
>> functions have
>> (put 'subword-forward 'CUA 'move)
>> so, I think it should be consistent.

In 24.3.92, cua-mode does not use its own shift-selection implementation
any more, so it is consistent by definition ;-)

You bug report does not say in which version you saw those problems, so
I'll assume it was 24.3 or earlier.  If you still see this problem in
the pretest (24.3.92), then please re-open or make a new report
providing additional details (e.g. indicating which commands are
affected).


        Stefan