all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* NS font resources
@ 2014-07-07 16:05 Dmitry Antipov
  2014-07-08  9:47 ` Jan Djärv
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2014-07-07 16:05 UTC (permalink / raw)
  To: Emacs development discussions

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]

Can someone test this small cleanup with trunk on OSX?
It seems that nobody cares about freeing these font resources...

Dmitry

[-- Attachment #2: nsfont_close.patch --]
[-- Type: text/x-patch, Size: 382 bytes --]

=== modified file 'src/nsfont.m'
--- src/nsfont.m	2014-07-04 02:28:54 +0000
+++ src/nsfont.m	2014-07-07 16:01:01 +0000
@@ -945,6 +945,8 @@
 	  xfree (font_info->glyphs[i]);
 	  xfree (font_info->metrics[i]);
 	}
+      xfree (font_info->glyphs);
+      xfree (font_info->metrics);
       [font_info->nsfont release];
 #ifdef NS_IMPL_COCOA
       CGFontRelease (font_info->cgfont);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: NS font resources
  2014-07-07 16:05 NS font resources Dmitry Antipov
@ 2014-07-08  9:47 ` Jan Djärv
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Djärv @ 2014-07-08  9:47 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: Emacs development discussions

Hello.

7 jul 2014 kl. 18:05 skrev Dmitry Antipov <dmantipov@yandex.ru>:

> Can someone test this small cleanup with trunk on OSX?

I makes more sense to test it on GNUStep, as nsfont.m is not used by default on OSX.
But it works OK on GNUStep, so please check in.  You could test GNUStep yourself, it is not hard to set up.

> It seems that nobody cares about freeing these font resources...
> 

Not many runs GNUStep Emacs.  

	Jan d.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-08  9:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-07 16:05 NS font resources Dmitry Antipov
2014-07-08  9:47 ` Jan Djärv

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.