Problem with CVS emacs on Mac OS X (Carbon) (related to tty_lookup_color?)

Problem with CVS emacs on Mac OS X (Carbon) (related to tty_lookup_color?)

[chad brown]

CVS Emacs built on Mac OS X 10.3.5 as of today (same yesterday) crashes 
in set-foreground-color if you attempt to use a color name with a space 
in it (such as Navajo White or Light Sky Blue).  The crash happens with 
set-background-color and set-cursor-color as well.  I first noticed 
this yesterday, with a then-current CVS build, but I had not updated 
for a few days prior to that.

Here is the stack trace.  It looks like it may be related to a 
change/discussion on tty_lookup_color that I recall seeing recently, 
but can no longer easily find.

Thank you,
*chad



Program received signal SIGABRT, Aborted.
0x900429ac in kill ()
(gdb) where
#0  0x900429ac in kill ()
#1  0x9009eb1c in abort ()
#2  0x000ec81c in Feval (form=-1073752108) at eval.c:2150
#3  0x000e978c in Fprogn (args=0) at eval.c:408
#4  0x000ee0c8 in unbind_to (count=0, value=58721281) at eval.c:3116
#5  0x0011b3c8 in Fbyte_code (bytestr=2692756, vector=2678804, 
maxdepth=2678804) at bytecode.c:708
#6  0x000edabc in funcall_lambda (fun=2678804, nargs=3, 
arg_vector=0x28a9cc) at eval.c:2944
#7  0x000ed5d8 in Ffuncall (nargs=0, args=0x28e014) at eval.c:2814
#8  0x0011b350 in Fbyte_code (bytestr=2692756, vector=2678804, 
maxdepth=2678804) at bytecode.c:686
#9  0x000edabc in funcall_lambda (fun=2678804, nargs=3, 
arg_vector=0x28a9cc) at eval.c:2944
#10 0x000ed5d8 in Ffuncall (nargs=0, args=0x28e014) at eval.c:2814
#11 0x0011b350 in Fbyte_code (bytestr=2692756, vector=2678804, 
maxdepth=2678804) at bytecode.c:686
#12 0x000edabc in funcall_lambda (fun=2678804, nargs=3, 
arg_vector=0x28a9cc) at eval.c:2944
#13 0x000ed5d8 in Ffuncall (nargs=0, args=0x28e014) at eval.c:2814
#14 0x000ed088 in call2 (fn=0, arg1=0, arg2=-1610604376) at eval.c:2569
#15 0x00071634 in tty_lookup_color (f=0x291694, color=2678804, 
tty_color=0x28e014, std_color=0x28e014) at xfaces.c:1319
#16 0x000717d4 in tty_defined_color (f=0x832690, color_name=0x29a6ec0 
"light sky blue", color_def=0xbfffe1c0, alloc=2692372) at xfaces.c:1385
#17 0x00071ac4 in face_color_supported_p (f=0x0, color_name=0x0, 
background_p=-1610604376) at xfaces.c:1512
#18 0x00071e54 in load_face_colors (f=0x832690, face=0x87a930, 
attrs=0xa00020a8) at xfaces.c:1679
#19 0x0007c148 in realize_x_face (cache=0x87a930, attrs=0x832690, 
c=42716899, base_face=0x8b2eb0) at xfaces.c:7141
#20 0x0007bd78 in realize_face (cache=0x832690, attrs=0x832690, c=3, 
base_face=0x38d2d13, former_face_id=2692756) at xfaces.c:7040
#21 0x0007bcdc in realize_named_face (f=0x832690, symbol=58756353, 
id=2692816) at xfaces.c:7006
#22 0x0007b60c in realize_basic_faces (f=0x44) at xfaces.c:6845
#23 0x00075cc8 in update_face_from_frame_parameter (f=0x28e23c, 
param=0, new_value=-1073749072) at xfaces.c:4496
#24 0x00146728 in x_set_foreground_color (f=0x44, arg=17, 
oldval=-1610604376) at macfns.c:1401
#25 0x00017344 in x_set_frame_parameters (f=0x3, alist=58756137) at 
frame.c:2735
#26 0x00016810 in Fmodify_frame_parameters (frame=8595092, 
alist=17333573) at frame.c:2284
#27 0x000ed488 in Ffuncall (nargs=0, args=0xbfffe7a0) at eval.c:2760
#28 0x0011b350 in Fbyte_code (bytestr=8595092, vector=17333573, 
maxdepth=-1073748064) at bytecode.c:686
#29 0x000edabc in funcall_lambda (fun=-1073748064, nargs=2675128, 
arg_vector=0x28a9cc) at eval.c:2944
#30 0x000ed5d8 in Ffuncall (nargs=0, args=0xbfffe7a0) at eval.c:2814
#31 0x000ecb84 in Fapply (nargs=2675128, args=0x28d1b8) at eval.c:2262
#32 0x000ecfe4 in apply1 (fn=60145777, arg=-1610596436) at eval.c:2515
#33 0x000e7e8c in Fcall_interactively (function=60145777, 
record_flag=58721329, keys=2664908) at callint.c:412
#34 0x0008e1a4 in Fcommand_execute (cmd=60145777, record_flag=42, 
keys=2249701, special=2692372) at keyboard.c:9724
#35 0x0008e4b0 in Fexecute_extended_command (prefixarg=2652904) at 
keyboard.c:9821
#36 0x000ed470 in Ffuncall (nargs=0, args=0xbfffeec0) at eval.c:2757
#37 0x000e8ec4 in Fcall_interactively (function=-1073746236, 
record_flag=2652904, keys=2664908) at callint.c:878
#38 0x0008e1a4 in Fcommand_execute (cmd=58762825, record_flag=1, 
keys=2675128, special=2692372) at keyboard.c:9724
#39 0x000827a0 in command_loop_1 () at keyboard.c:1779
#40 0x000eb228 in internal_condition_case (bfun=0x81554 
<command_loop_1>, handlers=58766401, hfun=0x80ebc <cmd_error>) at 
eval.c:1367
#41 0x000812f4 in command_loop_2 () at keyboard.c:1309
#42 0x000eac84 in internal_catch (tag=0, func=0x812b4 <command_loop_2>, 
arg=58721281) at eval.c:1128
#43 0x0008124c in command_loop () at keyboard.c:1288
#44 0x00080c1c in recursive_edit_1 () at keyboard.c:981
#45 0x00080db4 in Frecursive_edit () at keyboard.c:1042
#46 0x0007f7b0 in main (argc=0, argv=0xbffffdfc) at emacs.c:1738
(gdb)

Re: Problem with CVS emacs on Mac OS X (Carbon) (related to tty_lookup_color?)

[YAMAMOTO Mitsuharu]

>>>>> On Thu, 4 Nov 2004 16:27:27 -0500, chad brown <y@MIT.EDU> said:

> CVS Emacs built on Mac OS X 10.3.5 as of today (same yesterday)
> crashes in set-foreground-color if you attempt to use a color name
> with a space in it (such as Navajo White or Light Sky Blue).

This is not a Mac OS specific problem.  Actually it is yet another
instance of "eval while blocking input" abort.

In xfaces.c:

  static int
  realize_basic_faces (f)
       struct frame *f;
  {
    int success_p = 0;
    int count = SPECPDL_INDEX ();

    /* Block input here so that we won't be surprised by an X expose
       event, for instance, without having the faces set up.  */
    BLOCK_INPUT;
    specbind (Qscalable_fonts_allowed, Qt);

    if (realize_default_face (f))
  ...
    unbind_to (count, Qnil);
    UNBLOCK_INPUT;
    return success_p;
  }

And the call of realize_default_face may leads to Feval through

  color_desc = call2 (Qtty_color_desc, color, frame);

in tty_lookup_color.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp