From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@jurta.org>
Cc: 17554@debbugs.gnu.org, Roland Winkler <winkler@gnu.org>
Subject: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window
Date: Wed, 11 Jun 2014 09:15:06 +0200 [thread overview]
Message-ID: <539801FA.2040400@gmx.at> (raw)
In-Reply-To: <874mzs8jad.fsf@mail.jurta.org>
> The standard terminal size is 80x25. 80*2 = 160 which is a good
> default width for `split-width-threshold'. Correspondingly, 25*2 = 50
> would be a better default height for `split-height-threshold'
> to be changed in the trunk. (Another good change for the trunk
> is to use `display-buffer-at-bottom' for *Completions*).
What does it use currently?
> For the emacs-24 branch `split-window-preferred-function' won't help
> if the window height is smaller than `split-height-threshold',
We'd have to write our own `split-window-preferred-function' which would
set `split-height-threshold' accordingly. This is not entirely clean
though since we'd bind a user variable. A user could override it via
`display-buffer-alist' but this is not entirely obvious.
Usually, the right choice would be to pass appropriate functions via the
ACTION argument. Unfortunately, the `display-buffer' call issued for
*Completions* is virtually nested in the call for *Marked Files* which
makes things more complicated than expected.
(1) I wouldn't want to change the general behavior of how *Completions*
are presented just in order to fix the problem at hand.
(2) Changing the ACTION argument for the `display-buffer' call used to
show *Completions* such as to check whether a *Marked Files* buffer
is currently shown and avoid using that or the original dired window
is no viable alternative either.
(3) Marking any of the dired or *Marked Files* windows as dedicated is
somewhat dangerous (even when done softly) when the user quits the
*Completions* window in some non-standard, non-modal way.
(4) Using `display-buffer-overriding-action' is clearly to harsh.
> and *Completions* still will be displayed in the small window
> of *Marked Files*. This could be fixed only by displaying
> *Completions* in the window containing the Dired buffer
> (without using split-window) like it was in previous releases.
> This is why I tried to mark *Marked Files* as dedicated.
But the 24.3 code handles Roland's scenario by displaying *Completions*
in a third window. At least it does so here. What do you get?
martin
next prev parent reply other threads:[~2014-06-11 7:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:59 bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Roland Winkler
2014-05-23 1:07 ` Stefan Monnier
2014-05-23 2:17 ` Roland Winkler
2014-05-23 6:06 ` Eli Zaretskii
2014-05-23 7:24 ` martin rudalics
2014-05-23 21:32 ` Juri Linkov
2014-05-27 21:54 ` Juri Linkov
2014-05-27 22:45 ` Roland Winkler
2014-06-05 23:48 ` Juri Linkov
2014-06-06 1:07 ` Stefan Monnier
2014-06-06 4:17 ` Roland Winkler
2014-06-06 23:05 ` Juri Linkov
2014-06-09 16:15 ` Roland Winkler
2014-06-10 0:12 ` Juri Linkov
2014-06-10 6:07 ` martin rudalics
2014-06-10 22:57 ` Juri Linkov
2014-06-11 7:15 ` martin rudalics [this message]
2014-06-12 6:33 ` Juri Linkov
2014-06-16 6:51 ` Juri Linkov
2014-06-16 19:49 ` Roland Winkler
2014-06-16 21:47 ` Stefan Monnier
2014-06-17 6:44 ` Juri Linkov
2014-06-18 7:57 ` Juri Linkov
2014-06-06 23:04 ` Juri Linkov
2014-06-18 8:07 ` Juri Linkov
2014-05-23 5:48 ` Eli Zaretskii
2014-05-23 7:25 ` martin rudalics
2014-05-23 7:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539801FA.2040400@gmx.at \
--to=rudalics@gmx.at \
--cc=17554@debbugs.gnu.org \
--cc=juri@jurta.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.